Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test https://github.com/NREL/OpenStudio/pull/5194 #1242

Closed
wants to merge 4 commits into from
Closed

Test https://github.com/NREL/OpenStudio/pull/5194 #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5db60e1
Confirm segfault with rc2.
joseph-robertson May 14, 2024
643bc9a
Point config to test new docker image.
joseph-robertson May 14, 2024
8719471
Confirm segfault with rc2, try 2.
joseph-robertson May 14, 2024
b44ce2d
Point config to test new docker image, try 2.
joseph-robertson May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ jobs:
runs-on: ubuntu-latest
needs: [unit-tests]
container:
image: docker://nrel/openstudio:dev-3.8.0-rc2
# image: docker://nrel/openstudio:dev-3.8.0-rc2
image: docker://nrel/openstudio:dev-pr-5194
steps:
- uses: actions/checkout@v4
with:
Expand Down
6 changes: 3 additions & 3 deletions measures/UpgradeCosts/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def run(runner, user_arguments)

# Retrieve values from ApplyUpgrade, ReportHPXMLOutput
values = {}
# apply_upgrade = runner.getPastStepValuesForMeasure('apply_upgrade') # FIXME: this causes a segfault for some reason
# values['apply_upgrade'] = Hash[apply_upgrade.collect { |k, v| [k.to_s, v] }]
values['apply_upgrade'] = get_values_from_runner_past_results(runner, 'apply_upgrade')
apply_upgrade = runner.getPastStepValuesForMeasure('apply_upgrade') # FIXME: this causes a segfault for some reason
values['apply_upgrade'] = Hash[apply_upgrade.collect { |k, v| [k.to_s, v] }]
# values['apply_upgrade'] = get_values_from_runner_past_results(runner, 'apply_upgrade')
report_hpxml_output = runner.getPastStepValuesForMeasure('report_hpxml_output')
values['report_hpxml_output'] = Hash[report_hpxml_output.collect { |k, v| [k.to_s, v] }]

Expand Down
3 changes: 2 additions & 1 deletion resources/buildstock.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,8 @@ def self.run(in_osw, parent_dir, run_output, upgrade, measures, reporting_measur
command += ' -m' if measures_only
command += " -w \"#{in_osw}\""

system(command, [:out, :err] => File::NULL)
# system(command, [:out, :err] => File::NULL)
system(command)
run_log = File.readlines(File.expand_path(File.join(parent_dir, 'run/run.log')))
run_log.each do |line|
next if line.include? 'Cannot find current Workflow Step'
Expand Down
Loading