Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVAC Autosizing Factors #1218

Merged
merged 6 commits into from
Apr 9, 2024
Merged

HVAC Autosizing Factors #1218

merged 6 commits into from
Apr 9, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Mar 12, 2024

Pull Request Description

Companion PR: https://github.com/NREL/resstock-estimation/pull/406.

Options:

  • Option 1 - Update BuildExistingModel to set (perhaps based on system type):
    • heating_system_heating_autosizing_factor
    • cooling_system_cooling_autosizing_factor
    • heat_pump_heating_autosizing_factor
    • heat_pump_cooling_autosizing_factor
    • heat_pump_backup_heating_autosizing_factor
    • heating_system_2_heating_autosizing_factor
  • Option 2 - Introduce a new set of tsv files (https://github.com/NREL/resstock-estimation/pull/406):
    • HVAC System Is Scaled
    • HVAC Heating Autosizing Factor
    • HVAC Cooling Autosizing Factor

This PR implements Option 2.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson joseph-robertson added this to the ResStock v3.3.0 milestone Mar 12, 2024
@joseph-robertson joseph-robertson self-assigned this Mar 12, 2024
@afontani afontani marked this pull request as ready for review April 9, 2024 14:43
@afontani afontani self-requested a review April 9, 2024 14:43
@afontani afontani merged commit c0cf5de into develop Apr 9, 2024
@afontani afontani deleted the autosizing-factors branch April 9, 2024 14:47
@@ -19,6 +19,7 @@ Fixes
- Reorganize the emissions and utility rates data folders such that their sources and functions are more clear ([#1195](https://github.com/NREL/resstock/pull/1195))
- Move location of out-of-unit (shared) water heaters to conditioned mechanical room ([#1201](https://github.com/NREL/resstock/pull/1201))
- Update the Alaska residential stock characterization using the Alaska Retrofit Information System data ([#1214](https://github.com/NREL/resstock/pull/1214))
- Enable HVAC airflor and capacity scaling factors to oversize or undersize the equipment. ([#1218](https://github.com/NREL/resstock/pull/1218))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"airflor" typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants