Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AK integration #1092

Closed
wants to merge 8 commits into from
Closed

AK integration #1092

wants to merge 8 commits into from

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Jun 23, 2023

Pull Request Description

DRAFT PR updating housing characteristics for better Alaska modelling using ARIS dataset.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
    • If related to resstock-estimation, checklist includes data dictionary, source report, options_lookup
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@@ -0,0 +1,3 @@
Option=None Option=10% Served Option=20% Served Option=30% Served Option=40% Served Option=50% Served sampling_probability
Copy link
Contributor

@joseph-robertson joseph-robertson Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest naming this file something like "HVAC Secondary Heating Partial Space Conditioning.tsv" so that it is consistent with the existing "HVAC Cooling Partial Space Conditioning.tsv" file name.

@@ -32,7 +32,7 @@ workflow_generator:
- scenario_name: Bills

simulation_output_report:
timeseries_frequency: hourly
timeseries_frequency: 15min
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd want "timestep" here. And then you'd change simulation_control_timestep above to "15".

@rajeee
Copy link
Contributor Author

rajeee commented Mar 4, 2024

superseded by: #1214

@rajeee rajeee closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants