Skip to content

Commit

Permalink
Showing 3 changed files with 41 additions and 1 deletion.
1 change: 1 addition & 0 deletions openstudiocore/resources/model/OpenStudio.idd
Original file line number Diff line number Diff line change
@@ -10163,6 +10163,7 @@ OS:AirTerminal:SingleDuct:VAV:Reheat,
\default Normal
\key Normal
\key Reverse
\key ReverseWithLimits
N7, \field Maximum Flow per Zone Floor Area During Reheat
\note Used only when Reheat Coil Object Type = Coil:Heating:Water and Damper Heating Action = Reverse
\note When autocalculating, the maximum flow per zone is set to 0.002032 m3/s-m2 (0.4 cfm/sqft)
40 changes: 39 additions & 1 deletion openstudiocore/src/osversion/VersionTranslator.cpp
Original file line number Diff line number Diff line change
@@ -116,7 +116,7 @@ VersionTranslator::VersionTranslator()
m_updateMethods[VersionString("1.11.4")] = &VersionTranslator::update_1_11_3_to_1_11_4;
m_updateMethods[VersionString("1.11.5")] = &VersionTranslator::update_1_11_4_to_1_11_5;
m_updateMethods[VersionString("1.12.1")] = &VersionTranslator::update_1_12_0_to_1_12_1;
m_updateMethods[VersionString("1.13.4")] = &VersionTranslator::defaultUpdate;
m_updateMethods[VersionString("1.13.4")] = &VersionTranslator::update_1_12_3_to_1_12_4;


// List of previous versions that may be updated to this one.
@@ -3337,6 +3337,44 @@ std::string VersionTranslator::update_1_12_0_to_1_12_1(const IdfFile& idf_1_12_0
return ss.str();
}

std::string VersionTranslator::update_1_12_3_to_1_12_4(const IdfFile& idf_1_12_3, const IddFileAndFactoryWrapper& idd_1_12_4) {
std::stringstream ss;

ss << idf_1_12_3.header() << std::endl << std::endl;
IdfFile targetIdf(idd_1_12_4.iddFile());
ss << targetIdf.versionObject().get();

for (const IdfObject& object : idf_1_12_3.objects()) {
auto iddname = object.iddObject().name();

if (iddname == "OS:AirTerminal:SingleDuct:VAV:Reheat") {
auto iddObject = idd_1_12_4.getObject("OS:AirTerminal:SingleDuct:VAV:Reheat");
IdfObject newObject(iddObject.get());

for( size_t i = 0; i < object.numNonextensibleFields(); ++i ) {
if ( auto s = object.getString(i) ) {
if( i == 14u ) {
if ( istringEqual("Reverse",s.get()) ) {
newObject.setString(i,"ReverseWithLimits");
} else {
newObject.setString(i,s.get());
}
} else {
newObject.setString(i,s.get());
}
}
}

m_refactored.push_back( std::pair<IdfObject,IdfObject>(object,newObject) );
ss << newObject;
} else {
ss << object;
}
}

return ss.str();
}


} // osversion
} // openstudio
1 change: 1 addition & 0 deletions openstudiocore/src/osversion/VersionTranslator.hpp
Original file line number Diff line number Diff line change
@@ -212,6 +212,7 @@ class OSVERSION_API VersionTranslator {
std::string update_1_11_3_to_1_11_4(const IdfFile& idf_1_11_3, const IddFileAndFactoryWrapper& idd_1_11_4);
std::string update_1_11_4_to_1_11_5(const IdfFile& idf_1_11_4, const IddFileAndFactoryWrapper& idd_1_11_5);
std::string update_1_12_0_to_1_12_1(const IdfFile& idf_1_12_0, const IddFileAndFactoryWrapper& idd_1_12_1);
std::string update_1_12_3_to_1_12_4(const IdfFile& idf_1_12_3, const IddFileAndFactoryWrapper& idd_1_12_4);

IdfObject updateUrlField_0_7_1_to_0_7_2(const IdfObject& object, unsigned index);

0 comments on commit 0215062

Please sign in to comment.