Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Modeling Two Speed & Var Speed Geothermal Heat Pumps #1878

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Allow Modeling Two Speed & Var Speed Geothermal Heat Pumps #1878

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
100e02a
added test files, create coil object with placeholders
yzhou601 Nov 8, 2024
6c0629b
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Nov 25, 2024
f41d4f1
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Dec 19, 2024
74e100c
fix issues, add heating coil object
yzhou601 Dec 19, 2024
0788320
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Dec 26, 2024
346d8c9
added performance curves for two speed gshp, more assumptions and inp…
yzhou601 Dec 27, 2024
2182a8f
updated performance curves, capacity ratios, cfm/tons based on E+ rat…
yzhou601 Dec 28, 2024
cba4f31
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 9, 2025
4615f89
hvac sizing cleanups for two speed GSHP, added rated cop ratios at ea…
yzhou601 Jan 9, 2025
c883e62
bugfix
yzhou601 Jan 9, 2025
ed642d8
Added temperature max/min values to curves, fixed airflow and water f…
yzhou601 Jan 9, 2025
58e8142
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 9, 2025
7facd88
bugfixes, installation quality program(haven't finished yet)
yzhou601 Jan 10, 2025
b1512e2
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 10, 2025
d1d0cc8
oops, remove debugging statements
yzhou601 Jan 10, 2025
ab22fcc
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 16, 2025
1010b16
fix sizing unit test
yzhou601 Jan 17, 2025
7cabcbc
iq ems
yzhou601 Jan 17, 2025
302d4a8
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildResidentialHPXML/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5767,7 +5767,7 @@ def self.set_heat_pumps(hpxml_bldg, args)
end
end

if [HPXML::HVACTypeHeatPumpAirToAir, HPXML::HVACTypeHeatPumpMiniSplit].include? heat_pump_type
if [HPXML::HVACTypeHeatPumpAirToAir, HPXML::HVACTypeHeatPumpMiniSplit, HPXML::HVACTypeHeatPumpGroundToAir].include? heat_pump_type
compressor_type = args[:heat_pump_cooling_compressor_type]
end

Expand Down
6 changes: 3 additions & 3 deletions BuildResidentialHPXML/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>build_residential_hpxml</name>
<uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
<version_id>df4fe828-a827-4cc2-8a4d-9c8daf649202</version_id>
<version_modified>2024-12-20T20:07:27Z</version_modified>
<version_id>170de859-703b-4e20-8c4f-7f39aee3cae4</version_id>
<version_modified>2024-12-26T18:44:09Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>BuildResidentialHPXML</class_name>
<display_name>HPXML Builder</display_name>
Expand Down Expand Up @@ -7544,7 +7544,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>612549F4</checksum>
<checksum>35949896</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
8 changes: 4 additions & 4 deletions HPXMLtoOpenStudio/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>f5059b5f-8030-497a-bab2-94f90354de7e</version_id>
<version_modified>2024-12-20T20:07:28Z</version_modified>
<version_id>19d5093a-f3c0-4bef-90f5-10fde39d6b3c</version_id>
<version_modified>2024-12-27T00:31:20Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -327,7 +327,7 @@
<filename>defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>F2AE9AD3</checksum>
<checksum>A66CFFCE</checksum>
</file>
<file>
<filename>energyplus.rb</filename>
Expand Down Expand Up @@ -387,7 +387,7 @@
<filename>hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>759FC93A</checksum>
<checksum>A86AA813</checksum>
</file>
<file>
<filename>hvac_sizing.rb</filename>
Expand Down
3 changes: 3 additions & 0 deletions HPXMLtoOpenStudio/resources/defaults.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5345,6 +5345,9 @@ def self.get_hvac_compressor_type(hvac_type, seer)
when HPXML::HVACTypeMiniSplitAirConditioner,
HPXML::HVACTypeHeatPumpMiniSplit
return HPXML::HVACCompressorTypeVariableSpeed
when HPXML::HVACTypeHeatPumpGroundToAir
# TODO: default GSHP compressor type based on COP?
return HPXML::HVACCompressorTypeSingleStage
when HPXML::HVACTypePTAC,
HPXML::HVACTypeHeatPumpPTHP,
HPXML::HVACTypeHeatPumpRoom,
Expand Down
Loading
Loading