-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G function library #1412
G function library #1412
Conversation
… into g_function_library
I'll be dropping updates on JSON file parsing from the g-function library here since it is related, if that's OK. |
Saving the parsed JSONs here. Please take a look at the ones created and let me know if there are any comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other configurations catch JSON subsets accurately, but 'LopU' seems to have some missing still. Check 'M_N visualizations' sheet here.
…io-HPXML into g_function_library
… into g_function_library
Pull Request Description
Addresses #1202.
Add:
download_g_functions
totasks.rb
for fetching G-Function Library 1.0.zip from the Geothermal Data Repository (GDR)HPXMLtoOpenStudio/resources/g_functions/util.rb
withprocess_g_functions
method for "downselecting" contents of borehole configuration json filesUpdate:
bore_spacing
default value inhpxml_defaults.rb
from 20.0 ft to 16.4 ft (i.e., 5 m)gshp_gfnc_coeff
method inhvac_sizing.rb
to use data from G function library json filesChecklist for testing g-function linear interpolation:
process_g_functions
method inHPXMLtoOpenStudio/resources/g_functions/util.rb
to not exclude the test case (i.e., rectangular 5x8 configuration) spelled out in the "Interpolation Methodology" section of the documentation (LibraryOverview_v11.1.pdf)tasks.rb
withdownload_g_functions
argument to populate new json files that include the configuration to test againsthpxml_inputs.json
and add new sample file entries (seeBuildResidentialHPXML
measure forgeothermal_loop_xxx
arguments)tasks.rb
withupdate_hpxmls
to get new sample file(s)workflow/run_simulation.rb
with new sample file(s) as arguments, and print debug statements inhvac_sizing.rb
Questions:
bore_depth
? The json files have g functions for bore depths ranging from 24 m to 384 m. Update: I use a fail statement on anybore_depth
outside of the 24 to 384 m range.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedtasks.rb
)HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)openstudio tasks.rb update_measures
has been run