ANSI 301-2022: Airflow #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbf067fdcb Fix assert_in_epsilon tests. c3c95819d2 Simplify code. 9dabadd9b4 Update Changelog.md [ci skip] 1115e941ee Fix typo in docs. b704b1968c Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow d60d17e34b Updates equations for Qfan and hourly combining of infiltration/ventilation. c102844ee2 Oops. d6d594c8e8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022 513acded4f Latest results. ce3851566e Merge branch 'master' into ansi_301_2022 bdbf9cd0de Latest results. 67848fe81e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022 a9d0011a12 Latest results. cb3775f586 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022 25cade3703 Latest results. 6a137735c6 Remove natural ventilation RH constraint to comply with ANSI 301-2022; HR constraint is still in place. fe3dc91a5c Update default CFIS fan power. Fix ANSI 301 links in docs. 85b40864fe Update Qinf=f(NL) equation. bddcef9920 Prep for ANSI 301-2022. git-subtree-dir: hpxml-measures git-subtree-split: fbf067fdcbca53ee5f5d118ed227dda0883228a7
…_2022_airflow # Conflicts: # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb # hpxml-measures/HPXMLtoOpenStudio/tests/test_defaults.rb # hpxml-measures/docs/source/workflow_inputs.rst
46fe162b76 Merge branch 'ansi_301_2022_airflow' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 1092b38dee Handle case where Qinf > Qtot. 8db9c4dd9c Latest results. git-subtree-dir: hpxml-measures git-subtree-split: 46fe162b765a5211907e7660c1a99d83aa5c0897
REVERT: 46fe162b76 Merge branch 'ansi_301_2022_airflow' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow REVERT: 1092b38dee Handle case where Qinf > Qtot. REVERT: 8db9c4dd9c Latest results. REVERT: fbf067fdcb Fix assert_in_epsilon tests. REVERT: c3c95819d2 Simplify code. REVERT: 9dabadd9b4 Update Changelog.md [ci skip] REVERT: 1115e941ee Fix typo in docs. REVERT: b704b1968c Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow REVERT: d60d17e34b Updates equations for Qfan and hourly combining of infiltration/ventilation. git-subtree-dir: hpxml-measures git-subtree-split: c102844ee296e26c2e5dadb29428bd9eaa670388
d42c040f55 Minor refactoring. 46fe162b76 Merge branch 'ansi_301_2022_airflow' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 1092b38dee Handle case where Qinf > Qtot. 8db9c4dd9c Latest results. fbf067fdcb Fix assert_in_epsilon tests. c3c95819d2 Simplify code. 9dabadd9b4 Update Changelog.md [ci skip] 1115e941ee Fix typo in docs. b704b1968c Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow d60d17e34b Updates equations for Qfan and hourly combining of infiltration/ventilation. git-subtree-dir: hpxml-measures git-subtree-split: d42c040f55f0e69dc7be16d155514f03b23ca47e
6be89690f6 Expose WithinInfiltrationVolume inputs for some attic/foundation types. git-subtree-dir: hpxml-measures git-subtree-split: 6be89690f61aa7d3f2eebbc488741f5a9e93271b
…tudio-ERI into ansi_301_2022_airflow
…into ansi_301_2022_airflow # Conflicts: # workflow/tests/base_results/real_homes.csv
…tudio-ERI into ansi_301_2022_airflow
dc687d155e Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 14fb976588 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022 0d2ad4c32e Merge pull request #1590 from NREL/revert_xmlvalidator 5e0f974989 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into revert_xmlvalidator 451001898c Merge pull request #1589 from NREL/flatten_documentation 7cb579f037 Some cleanup/fixes. 612c71105d Update test. 9d22e625c0 Update BuildResHPXML measure links. 188a92825c Handle hot water distribution [ci skip] 53249533f4 Handle solar thermal [ci skip] c482b8eb41 Use consistent language [ci skip] ec645b9a5e Handle ventilation fans. [ci skip] 32f2f2c567 Address HVAC distribution [ci skip] 5305dbff27 Address water heaters. [ci skip] 80c4a2586a Address heat pumps [ci skip] a1db341e67 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022 d2191ea01f Merge pull request #1577 from NREL/ansi_301_2022_programmable_thermostat a5934e0e09 Remove Changelog.md entry [ci skip] 1c83895eb8 Update measure.xml [ci skip] 7292979287 Try reverting XMLValidator workaround for NREL/OpenStudio#4824. 00f8b38767 Merge branch 'ansi_301_2022_programmable_thermostat' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_programmable_thermostat 287d318baa Revert changes in test_defaults [ci skip] a4fdb6476f Latest results. 72c5f982f3 Fix default heating/cooling setpoints when there's no HVAC system b9b2eef38b Flatten HVAC heating and cooling systems. [ci skip] 9d6504d6c3 Clarify operable window area [ci skip] 9345750def Minor stuff. [ci skip] 4eae84d5f5 Run update_measures [ci skip] 42143ff8b9 Update changelog [ci skip] 5b5b964f95 Fix test_defaults.rb 03173ee833 Bugfix 0890573cab Simplify getting default setpoints for HVAC control type manual bd4c75beec Update HPXMLtoOpenStudio/resources/hpxml_defaults.rb 595311b61d Merge pull request #1583 from NREL/perf-data-args 970991b687 A little more clarification that min/max refer to speeds, not the capacities/cops themselves. Also adds more conditionals on when we attach the detailed performance data to cooling systems or heat pumps. c1d7100790 Update argument names and descriptions. a6b697c506 Merge branch 'master' into perf-data-args 9fb96818d8 Latest results. c2598cc89b Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_programmable_thermostat 78ad111379 Use 24-hr weekday/weekend setpoints for older ERI versions be7cf3a60f Add build tests for errors. 294004fb47 Update hpxml_inputs json. 4670c314e3 Simplify new perf data arguments. 9d36c872c8 Merge branch 'master' into perf-data-args 03d3c8f477 Generate detailed performance sample files using build measure. d80b4f80ce Add detailed performance data arguments. 3f5105ea24 Run update_measures 6696a7e5b6 Support 301-2022 programmable thermostat schedules git-subtree-dir: hpxml-measures git-subtree-split: dc687d155e77b6303ab13769fe58c4313c8c5505
…into ansi_301_2022_airflow # Conflicts: # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/docs/source/workflow_inputs.rst # workflow/tests/base_results/real_homes.csv
…into ansi_301_2022_airflow
…into ansi_301_2022_airflow
shorowit
added a commit
that referenced
this pull request
Feb 20, 2024
into ansi_301_2022_airflow # Conflicts: # hpxml-measures/Changelog.md # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb # hpxml-measures/HPXMLtoOpenStudio/resources/hpxml_defaults.rb # hpxml-measures/HPXMLtoOpenStudio/resources/hvac_sizing.rb # hpxml-measures/HPXMLtoOpenStudio/tests/test_defaults.rb # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1_bills.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2_bills.csv # rulesets/resources/301ruleset.rb
b10fd27d1e Latest results. 1a02a94d30 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 6050925349 Latest results. 5ff6774afa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 45cdd444fd Latest results. 6d6d0177e0 Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow dc687d155e Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 6be89690f6 Expose WithinInfiltrationVolume inputs for some attic/foundation types. d42c040f55 Minor refactoring. 46fe162b76 Merge branch 'ansi_301_2022_airflow' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 1092b38dee Handle case where Qinf > Qtot. 8db9c4dd9c Latest results. fbf067fdcb Fix assert_in_epsilon tests. c3c95819d2 Simplify code. 9dabadd9b4 Update Changelog.md [ci skip] 1115e941ee Fix typo in docs. b704b1968c Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow d60d17e34b Updates equations for Qfan and hourly combining of infiltration/ventilation. git-subtree-dir: hpxml-measures git-subtree-split: b10fd27d1e08dc2ef27e9eddca93c9b2661e498a
…_2022_airflow # Conflicts: # hpxml-measures/Changelog.md # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb # hpxml-measures/HPXMLtoOpenStudio/resources/hpxml_defaults.rb # hpxml-measures/HPXMLtoOpenStudio/tests/test_defaults.rb # hpxml-measures/workflow/tests/base_results/results_sizing.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1_bills.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2_bills.csv
…lemental balanced vent.
into ansi_301_2022_airflow # Conflicts: # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb # hpxml-measures/workflow/tests/base_results/results_sizing.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1_bills.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2_bills.csv # rulesets/resources/301ruleset.rb # rulesets/tests/test_ventilation.rb # workflow/tests/base_results/EPA_Tests.csv # workflow/tests/base_results/RESNET_Test_4.2_HERS_AutoGen_Reference_Home.csv # workflow/tests/base_results/RESNET_Test_4.3_HERS_Method.csv # workflow/tests/base_results/RESNET_Test_Other_HERS_AutoGen_Reference_Home_301_2014.csv # workflow/tests/base_results/RESNET_Test_Other_HERS_AutoGen_Reference_Home_301_2019_PreAddendumA.csv # workflow/tests/base_results/RESNET_Test_Other_HERS_Method_301_2014_PreAddendumE.csv # workflow/tests/base_results/RESNET_Test_Other_HERS_Method_301_2019_PreAddendumA.csv # workflow/tests/base_results/real_homes.csv # workflow/tests/base_results/sample_files1.csv # workflow/tests/base_results/sample_files2.csv
f88480c299 Latest results. 2e37ac4454 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow b10fd27d1e Latest results. 1a02a94d30 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 6050925349 Latest results. 5ff6774afa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 45cdd444fd Latest results. 6d6d0177e0 Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow dc687d155e Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 6be89690f6 Expose WithinInfiltrationVolume inputs for some attic/foundation types. d42c040f55 Minor refactoring. 46fe162b76 Merge branch 'ansi_301_2022_airflow' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow 1092b38dee Handle case where Qinf > Qtot. 8db9c4dd9c Latest results. fbf067fdcb Fix assert_in_epsilon tests. c3c95819d2 Simplify code. 9dabadd9b4 Update Changelog.md [ci skip] 1115e941ee Fix typo in docs. b704b1968c Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_airflow d60d17e34b Updates equations for Qfan and hourly combining of infiltration/ventilation. git-subtree-dir: hpxml-measures git-subtree-split: f88480c29951a2f9bd4fe705fd92509a45cb6781
…_2022_airflow # Conflicts: # hpxml-measures/HPXMLtoOpenStudio/measure.xml # hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb # hpxml-measures/workflow/tests/base_results/results_sizing.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations1_bills.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2.csv # hpxml-measures/workflow/tests/base_results/results_workflow_simulations2_bills.csv
55a199a0ad Merge pull request #1586 from NREL/ansi_301_2022_airflow bfbebabe1f Update docs [ci skip] 37d501c322 Clarify garage location. git-subtree-dir: hpxml-measures git-subtree-split: 55a199a0ade2344536c0477833c9c5302ba1feb1
39f10fcb07 Simplify AverageCeilingHeight default. 18ebd08c15 Merge pull request #1325 from NREL/geb-hvac-var-speed 333268bd3c Latest results. d9c0fd28fe Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 02d4d2b9e6 Merge pull request #1644 from NREL/cleanup_acca_hpxmls f9ce81a4d0 Update measures c587c454ff Clean up ACCA HPXML test files. 9485f91c65 Merge pull request #1643 from NREL/bugfix_tiny_infiltration fa573d8a26 Use zero. 51918f01c1 Handle tiny infiltration values. 4024fa48a4 Latest results. 8484518994 some more explanation in the docs f878dfc0c1 two var speed systems 3e790138e4 address comments d2c17943fa Revert "Allow daily temperature range to be provided for Manual J calc." 360791e809 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 621526332a Allow daily temperature range to be provided for Manual J calc. a69019133b A little cleanup while reviewing the PR. b5d60f8744 Latest results. 7c49fa9264 Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed d1b66641fa update_measures fd6a32f1bc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 265df5d22e Latest results. d3e95f5682 fix indent cd19c07ec2 fix simulation error e1b97aa25d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 794b7ba893 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 2ad08ac500 More description of the hvac_maximum_power_ratio schedule. Including calling it an "advanced research feature" 62055685ce Latest results. b8748a5a8c Minor cleanup in Changelog.md 7e4909c1f5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed a0e14cd04f address two speed system warning 03d3488562 Minor tweaks to changelog and docs. [ci skip] 4f3209d580 Latest results. 7ac1ad9fab typo cc643f6e7b Adds a return before throwing warning. d382172ca9 The fix was not correct, try this. 08f10b4126 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 55599312b8 throw warning only if there's no var speed system 410d5a43c1 Latest results. 38cd6feab4 try directly using path name to exclude maximum power schedule files 18f988ac27 bugfixes fe8942c5f7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed c1ad4e2baf Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed cccfc19518 address comments 98b0159e6f Update Changelog.md 294bf1e1f3 Latest results. 74dd169559 Update HPXMLtoOpenStudio/resources/hvac.rb abca3c47e1 Update HPXMLtoOpenStudio/resources/hvac.rb 4de04ab933 Update Changelog.md 7e666c1855 Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 221ba44740 remove old results 7d242cfa1e Latest results. 4205a7eb3d fix 10x test de3dbfd118 added cooling/heating checks for EMS statement creation ea3d6b73fe fix unit test, added a few additional test files, rename max capacity to max power ratio 99431da496 added unit test, disallowed multiplier da67f24464 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed c960918aa3 fix doc 846870b322 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 631d814db1 update measures ce0274e7b5 Approach improvements: 1. add setpoint sensors for cooling and heating individually 2. add plf curves 3. fix cooling power calculation based on total capacity 0423b3b1c8 Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed c9b0bd0f55 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 51c2075475 Latest results. acf292267b oops 504d5f1dae fix the cooling only test file, fix the current power calculations based on speed ratios d6bb23efd2 update measures e3bbf9163f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 2d8537de20 approach improvement to use load sensors and new control specifications, and a few cleanups 850d07d5d6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 44ed526c5e Latest results. c3bf29cb5a update measures c98e6256ab bugfixes and EMS cleanups 10a8f85da2 one more typo d84c7ee93b rename sensors ad0e8e5267 update measures and hpxmls 1fe138de81 fixed typos c0fac75589 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 158312a940 update hpxmls and some bugfixes 49f38db1e9 first cut ab0e612943 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 3fcdd58afd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 28164b61fa Latest results. 13f5cc8b3b Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 9b1126d656 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 527309cd8f Latest results. fc01ecdd89 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 0699bff691 Latest results. 0c7544fe89 Fix duplicate code. aa642efdd1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed b04fc664fc Latest results. 697a14e288 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 395e1ca255 changes based on last discussion with jeff 897b8fcd3e Latest results. 3b4ff8d4bb Merge branch 'os360' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 2c98b9daa5 Latest results. c3721bba30 Merge branch 'os360' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 6ae7e490f6 backup coil control 40b594c11b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 5f3eac1d16 Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 1ff536181e Update variable schedule for HVAC GEB d94386206a Merge branch 'geb-hvac-var-speed' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 3232ee33cf doc 18a0997eca fix unit test 64c3f350c0 Latest results. 767d88b31f use varied ratio schedule, minor change to EMS program cda72506f8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed f64e57e708 Adding variable schedule for testing out CTA signals for variable speed HVAC. 90d5489d64 Latest results. 9a3fe8778c fix EMS program 947036ff65 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed ef0e84b8c9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 4d977c910c implementation first cut c5561f0a44 Merge branch 'os360' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 4d571fd884 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 8d81e907d8 bugfix for method argument e182cbbcaf forgot to commit tasks.rb 05ae60558d var speed first cut 978f03ddfc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into geb-hvac-var-speed 23e12af59f first cut git-subtree-dir: hpxml-measures git-subtree-split: 39f10fcb07c2287c10f767739e1f8d3c027664e4
fc7bec4e8f Switch to ASHRAE 62.2 default. 1011d6b37b Clarify description [ci skip] git-subtree-dir: hpxml-measures git-subtree-split: fc7bec4e8f0a134494ce52bbcefa84842cfd71d4
e4a03fb770 Merge branch 'average_ceiling_height_default' of https://github.com/NREL/OpenStudio-HPXML into average_ceiling_height_default 024f4d1b3c Update ASHRAE 140 files. 3b42eaeb1b Latest results. git-subtree-dir: hpxml-measures git-subtree-split: e4a03fb770f83ca17c30e323b7d312f9330e666a
…tudio-ERI into ansi_301_2022_airflow
…tudio-ERI into ansi_301_2022_airflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[description here]
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
openstudio tasks.rb update_measureshas been run