PowerFlows.jl unified develop branch
#53
Conversation
Those sections being
| get_converged(pfd::PowerFlowData) = pfd.converged | ||
| get_solver_data(pfd::PowerFlowData) = pfd.solver_data | ||
|
|
||
| function clear_injection_data!(pfd::PowerFlowData) |
There was a problem hiding this comment.
@GabrielKS should we have a clear method that clears all fields?
There was a problem hiding this comment.
This is used in the power flow in the loop to set all bus injections to zero specifically to enable us to loop over generators and +=. I don't think that's relevant for any other fields, so I wouldn't say that's a priority.
| get_active_power_limits_for_power_flow(gen::PSY.RenewableDispatch) = | ||
| (min = 0.0, max = PSY.get_rating(gen)) | ||
|
|
||
| # TODO verify whether this is the correct behavior for Storage, (a) for redistribution and (b) for exporting |
There was a problem hiding this comment.
open an issue for this. We don't know what the correct approach is yet.
| end | ||
|
|
||
| function load_test_system() | ||
| # TODO commit to either providing this file or not requiring it |
There was a problem hiding this comment.
Note that much of the testing here depends on this system_240[32].json file that's not in the case builder. I believe there are plans to eventually put it there, so for now I am gracefully skipping those tests if the file doesn't exist for a given setup — do reviewers (@jd-lara) have input on that?
The
hrgks/psse_exporter_psy4branch has become a unifieddevelop-type branch for lots of new PowerFlows.jl functionality. It now contains the PSS/E exporter implementation as well as some new power flow implementations from @rbolgaryn. Pull requests include:PowerFlowDatafields for multi-period AC PF #78plus some more commits only in this branch.