Implement 1.8 BWBlock and BWItem rendering #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
============================================
- Coverage 13.49% 13.38% -0.12%
Complexity 711 711
============================================
Files 408 409 +1
Lines 12651 12757 +106
Branches 1337 1348 +11
============================================
Hits 1707 1707
- Misses 10828 10934 +106
Partials 116 116
Continue to review full report at Codecov.
|
ExE-Boss
force-pushed
the
bw-baked-model
branch
5 times, most recently
from
a44f9df to
9407ada
Compare
ExE-Boss
commented
Mar 4, 2017
| @@ -71,17 +87,22 @@ public FWSmartModel() { | |||
| .stream() | |||
| .flatMap( | |||
| model -> { | |||
| if (model instanceof MeshModel) { | |||
| if (model instanceof BWBakedModel) { | |||
| return Stream.concat(((BWBakedModel) model).getGeneralQuads().stream(), | |||
There was a problem hiding this comment.
Get rid of this bit, as BWBakedModel.clone() returns an instance of MeshModel and this bit doesn’t get called.
ExE-Boss
added
in progress
ExE-Boss
added
done
ExE-Boss
removed
the
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements backward rendering of Minecraft 1.8 Blocks and Items.
Depends on:
Completed:
MeshModelwrapper (BWBakedModel) for Minecraft'sIBakedModelBWBakedModelparse according toVertexFormat.Split off from #252, partially implements #104