Update csv2catchmentnetcdf.py issue #710 #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issue NOAA-OWP#710. In line 79, when parsing the date column, using the dictionary, as was done before this edit, pandas attempts to parse the column at index 0, to a column 'Time'. So, if 'Time' is already a column the error in issue NOAA-OWP#710 is produced. The proposed change assumes column at index 0 is the date column, but works despite the name.
hellkite500
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #710.
In line 79, when parsing the date column, using the dictionary, as was done before this edit, pandas attempts to parse the column at index 0, to a column 'Time'. So, if 'Time' is already a column the error in issue #710 is produced.
The proposed change assumes column at index 0 is the date column, but works despite the name.
[Short description explaining the high-level reason for the pull request]
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support