-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hand FIM improvements #944
Conversation
We might want to double check which fields from the that table show up in the UI. There may be UI columns that the field want to see. Update here on what you find as I can take it back to FIM-Dev and find out why they are submitting those columns to HV. |
I'm not sure I understand what you mean. The code is not discarding any columns that were not already being discarded. |
doh.. on nothing. I am a dork. I was mis-reading the FIM-dev input dataset. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you!
The biggest change is selective column loading for csv files. This could potentially significantly reduce memory usage.
The rest of the changes are relatively minor.
...and other minor fixes that simplify the code.