Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand FIM improvements #944

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Hand FIM improvements #944

merged 7 commits into from
Nov 6, 2024

Conversation

groutr
Copy link
Contributor

@groutr groutr commented Nov 5, 2024

The biggest change is selective column loading for csv files. This could potentially significantly reduce memory usage.

The rest of the changes are relatively minor.

  • np.where(condition) is an inefficient way of masking an array. It's about 2x slower and allocates an extra array.
  • sorting values is not an efficient way to find the max.
    ...and other minor fixes that simplify the code.

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Nov 5, 2024

We might want to double check which fields from the that table show up in the UI. There may be UI columns that the field want to see. Update here on what you find as I can take it back to FIM-Dev and find out why they are submitting those columns to HV.

@groutr
Copy link
Contributor Author

groutr commented Nov 5, 2024

I'm not sure I understand what you mean. The code is not discarding any columns that were not already being discarded.

@RobHanna-NOAA
Copy link
Contributor

doh.. on nothing. I am a dork. I was mis-reading the FIM-dev input dataset. :)

Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you!

@shawncrawley shawncrawley merged commit 13e0f4f into NOAA-OWP:ti Nov 6, 2024
1 check passed
@nickchadwick-noaa nickchadwick-noaa added this to the V2.1.8 milestone Jan 8, 2025
@nickchadwick-noaa nickchadwick-noaa linked an issue Jan 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve Alaska HAND FIM Processing Memory bottleneck
4 participants