Fixes rfc_max_forecast issue where view did not exist by creating the view on deploy #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying the latest uat branch to UAT, the rfc_max_forecast service was failing to execute because the rnr.flow_thresholds and rnr.stage_thresholds views did not exist. I had created them manually during testing and in my short-sidedness excluded the code that would ensure they get created across new environments on deploy. Here it is now.
Note: I really hope that the logic I added in Core/EC2/RDSBastion/scripts/utils/setup_foreign_tables.tftpl is correct. I was not able to test it, but did all the due diligence I could to ensure it is sound.