Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viz_classes code cleanup #1073

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Viz_classes code cleanup #1073

merged 3 commits into from
Jan 30, 2025

Conversation

groutr
Copy link
Contributor

@groutr groutr commented Jan 30, 2025

Some very minor cleanup of some code in viz_classes. Changes include:

  1. Using raw strings to properly escape regex tokens. This silences some warnings.
  2. Properly close the sql files that are opened
  3. Use native set difference instead of manually computing it with a list comprehension.

ping: @shawncrawley

shawncrawley
shawncrawley approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shawncrawley shawncrawley merged commit a16fa9f into NOAA-OWP:ti Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawncrawley shawncrawley shawncrawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groutr @shawncrawley