Update BMI C++ header to match upstream with virtual dtor and correct namespace #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf NOAA-OWP/ngen#831 for the reasoning behind the virtual destructor inspiring the update.
The namespace change is to address the technicality that
bmi::Bmi*
is not actually equivalent tobmixx::Bmi*
, even though the class definitions may be identical, and that difference technically entails Undefined Behavior when they're conflated in ngen.Changes
class Bmi
to match upstream with its virtual destructornamespace bmi
as upstream, and not a customnamespace bmixx
to avoid UBTesting
Notes
Checklist