updating LASAM to take field capacity as a parameter in the config file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, in the same style as wilting point. I also updated the calibratable params list in bmi_lgar.hxx to include field capacaity, as well as max ponded head. I also edited that list to not include vg_m and instead use vg_n, because the parameters file provides n rather than m.
ajkhattak
requested changes
Apr 11, 2024
There was a problem hiding this comment.
@peterlafollette have you tested if the newly added calibratable parameters are working properly? It looks to me that they are not, they are also not included in the calibratable params struct (here)
|
Updated so that unit tests pass with n rather than m, will add max ponded depth and field capacity to unit test for calibration today / tomorrow |
added 3 commits
April 11, 2024 18:33
…and maximum ponded head
…ta issues in the unit test. Unit test values should now be correct. Added precision to unit test benchmark values. Also fixed a bug where GetValuePtr should now work for field capacity and max ponded head.
|
Updated so that unit test checks calibration for all calibratable variables, including n, max ponded depth, and field capacity. |
added 7 commits
April 12, 2024 09:01
…mi_params for max ponded depth and field capacity. Apparently it gives the same results, but this update makes all calibratable parameters get pointers from GetValuePtr.
… apply to the whole model domain, and some parameters apply to individual soil layers. In the last commit, all calibratable parameters were updated correctly, but all parameters were printed for each soil layer, implying that some of the parameters that applied to the whole model domain actually only applied to individual layers. Now, printing updated calibrated parameters has two sections, one for layer dependent parameters, and one for layer independent.
…everting these, and keeping calibratable parameters in realization files
ajkhattak
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
In this PR, LASAM has been mildly refactored in order to have the field capacity be a user-specified parameter in the config file, in the same style as wilting point. I also updated the calibratable params list in bmi_lgar.hxx to include field capacity, as well as max ponded head. I also edited that list to not include vg_m and instead use vg_n, because the parameters file provides n rather than m.
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other