This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fix Trivy CI failures #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have dependabot to help keep up with updates so it's safer to track a released version. I'm also hoping using a particular release will resolve a CI failure we've been seeing.
For some reason the Trivy GitHub action has decided to ignore the severity configuration unless also given the "limit-severities-for-sarif" config. Trivy v0.14 fixed a bug that was hiding the return value. However, this meant that Trivy was now returning as failed for any low and medium severities.
ian-noaa
force-pushed
the
437-trivy-security-scan-is-erroneously-failing
branch
from
8bc7ae3 to
22d2d73
Compare
Minimum allowed line rate is |
ian-noaa
changed the title
esheehan-gsl
approved these changes
Nov 10, 2023
esheehan-gsl
deleted the
437-trivy-security-scan-is-erroneously-failing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have dependabot to keep our GitHub Actions up-to-date, switch to using a specific Trivy release.
Additionally, the latest Trivy release fixed a bug that was hiding a misconfiguration in our pipelines. For some reason, the GitHub Action Trivy publishes has decided to diverge from its CLI tool's behavior and ignore the
severity: CRITICAL,HIGHconfiguration unless thelimit-severities-for-sarif: trueoption is also set. When coupled with theexit-code: 1config option we had set, this meant Trivy would exit with an error code of 1 when it found any vulnerability, not just a critical or high vulnerability like we were anticipating.