Add a model-name dependence for some cloud fields #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshartsough
approved these changes
Feb 28, 2024
|
Hi @cshartsough — The main rationale for this PR is the ceiling-exp2 field. A previous PR changed the handle for this field to work with RRFS output, but the same PR inadvertently caused HRRR graphics to stop for this field. With this update, hopefully we will see the ceiling-exp2 plots from both the RRFS and HRRR (each using different handles for the same field). |
|
That's good, I think it should do the trick nicely. |
|
I am going to let this run in a RRFS retro overnight, just as a quick test. I will follow-up once I have some successful plots. |
|
@cshartsough @Brian-Jamison — My tests have worked, so I think this PR is ready for merging. |
jaymes-kenyon
requested review from
christinaholtNOAA,
Brian-Jamison and
kayeekayee
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update uses the model name to correctly assign handles for the ceiling (exp-2) and cloud-base height fields.