Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated constraints to reflect incoming new versions of subrepositories #94

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Updated constraints to reflect incoming new versions of subrepositories #94

merged 1 commit into from
Sep 13, 2024

Conversation

fmalatino
Copy link
Contributor

Description
This PR updates the constraints.txt file to reflect the incoming changes from the new NDSL release 2024.09.00

How Has This Been Tested?
Ensured new constraints create usable environment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino requested review from bensonr and mlee03 September 13, 2024 14:59
FlorianDeconinck
FlorianDeconinck approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bensonr
bensonr approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the completeness

@fmalatino fmalatino merged commit 6915fc3 into NOAA-GFDL:develop Sep 13, 2024
2 checks passed
@fmalatino fmalatino deleted the update/constraints branch September 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlee03 mlee03 mlee03 approved these changes

@bensonr bensonr bensonr approved these changes

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmalatino @FlorianDeconinck @bensonr @mlee03