Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pace to use python 3.11.9 #82

Merged
merged 9 commits into from
May 17, 2024
Merged

Update pace to use python 3.11.9 #82

merged 9 commits into from
May 17, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Apr 24, 2024 •
edited
Loading

Description
Updates to constraints and requirements to enable the use of python 3.11.9

How Has This Been Tested?
Tested using the main unit tests in tests/main

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino marked this pull request as ready for review April 24, 2024 12:07
@fmalatino fmalatino marked this pull request as draft April 24, 2024 12:08
@fmalatino fmalatino changed the title Updates to allow use of python3.11 Update pace to use python 3.11 Apr 24, 2024
@fmalatino fmalatino mentioned this pull request Apr 24, 2024
Closed
mlee03
mlee03 reviewed May 1, 2024
View reviewed changes
.github/workflows/main_unit_tests.yml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer needed, the tests triggered with this workflow now run in containers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good will remove

@fmalatino fmalatino requested a review from mlee03 May 1, 2024 16:09
@mlee03
Copy link
Collaborator

mlee03 commented May 6, 2024

Could we use this PR to test the updated images?
Two additional changes are required, the tag has to be updated to 3.11.9 in here and here

@fmalatino
Copy link
Contributor Author

Could we use this PR to test the updated images? Two additional changes are required, the tag has to be updated to 3.11.9 in here and here

Can do. Will update and re-push

@fmalatino fmalatino requested review from xyuan, oelbert and bensonr May 6, 2024 18:46
@fmalatino fmalatino marked this pull request as ready for review May 6, 2024 18:46
@fmalatino fmalatino changed the title Update pace to use python 3.11 Update pace to use python 3.11.9 May 6, 2024
mlee03
mlee03 approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mlee03 mlee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay CI works.

xyuan
xyuan approved these changes May 8, 2024
View reviewed changes
Copy link

@xyuan xyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is great job

@FlorianDeconinck
Copy link
Collaborator

NB: this will break orchestration, we have failures with py 3.11.X. I am fixing it DaCe side. Should not block for now, we have CI coverage issues anyway we will discuss on Friday

oelbert
oelbert approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmalatino fmalatino merged commit 3fa59a8 into NOAA-GFDL:develop May 17, 2024
6 checks passed
@fmalatino fmalatino deleted the fix/python_update branch June 4, 2024 15:38
fmalatino added a commit that referenced this pull request Jan 6, 2025
@fmalatino @oelbert @mlee03
Update Benchmark branch to use NDSL v2024.09.00 (#96)
c64fa64 
* working baroclinic test case example (#81)

* fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84)

* Update notebooks for eta file creations  (#85)

* Update pace to use python 3.11.9 (#82)

* Updated container for Github Action and reusable workflow (#87)

* Updated container for Github Action and reusable workflow - Redo (#89)

* Matching packages between main and develop branches and removal of outdated pull request template (#86)

* Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt

* Updating constraints file

* Updating Dockerfile to use 3.11-slim-bookworm base python image

* reusable workflow CI - checkout corrrect repository (#90)

* pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92)

* Updated README to include directions for generating eta files (#99)

* Updated submodules to most recent versions as of 3 Jan 2025 15:35 EST

* Updated c5 build script to match new methods

---------

Co-authored-by: Oliver Elbert <[email protected]>
Co-authored-by: MiKyung Lee <[email protected]>
Co-authored-by: mlee03 <[email protected]>
Co-authored-by: Xingqiu Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlee03 mlee03 mlee03 approved these changes

@oelbert oelbert oelbert approved these changes

@xyuan xyuan xyuan approved these changes

@bensonr bensonr Awaiting requested review from bensonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmalatino @mlee03 @FlorianDeconinck @xyuan @oelbert