Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_eta.py #77

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

mlee03
Copy link
Collaborator

@mlee03 mlee03 commented Mar 29, 2024

Description
The unit tests in test_eta.py have been updated with a more thorough checking of error messages upon failure.

Fixes #76

How Has This Been Tested?
The unit tests pass in pace_mpich:3.8 container

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino requested a review from oelbert March 29, 2024 17:31
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 972711e into NOAA-GFDL:develop Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test_eta.py
3 participants