hotfix for ntiles in driver dycore config for doubly periodic runs #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lharris4
reviewed
Mar 1, 2024
| @@ -280,6 +280,8 @@ def from_dict(cls, kwargs: Dict[str, Any]) -> "DriverConfig": | |||
| # Copy grid_type to the DycoreConfig if it's not the default value | |||
| if grid_type != 0: | |||
| kwargs["dycore_config"].grid_type = grid_type | |||
| if grid_type > 3: | |||
There was a problem hiding this comment.
I am hoping that in the future we can use a better coding for grid type than just integers. Python's datatypes allow more flexibility than do Fortran integers.
There was a problem hiding this comment.
It is logged: #29
There was a problem hiding this comment.
Yeah that's absolutely in the cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes the ntiles attribute of dycore config for doubly-periodic configurations, which was always set to 6 before
Code changes:
driver/pace/driver/driver.py: ntiles attribute of dycore config is now set to 1 for doubly periodic grid setupsChecklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updatedAdditionally, if this PR contains code authored by new contributors: