Add ocean temp and rough heat in for shield coupling #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaokun227
reviewed
Sep 17, 2024
bensonr
previously approved these changes
Sep 24, 2024
|
@JosephMouallem This will require updates in other repositories, including atmos_null. Can you link the PR updates that are required for this to go through? |
|
For our future reference reference, this PR will require updates in atmos_null and atmos_drivers, the corresponding PRs to those repos are: There is also a PR made to the internal gitlab repo: fms/atmos_solo_land |
|
@JosephMouallem You have a linter violation that's failing the CI. Please fix it before this can be merged. |
bensonr
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ocean temperature and rough heat to
land_ice_atmos_boundaryto used and populated on the exchange grid from ocean variables insfc_boundary_layer, before running the atmos physics for shield coupling.Contact: Joseph and Kun