Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling when variable_id/realm is unavailable #96

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Better error handling when variable_id/realm is unavailable #96

merged 1 commit into from
Jan 2, 2025

Conversation

Ciheim
Copy link
Contributor

@Ciheim Ciheim commented Nov 25, 2024

Adds a try/except so we can print a nice error message

@Ciheim Ciheim changed the title #95 Better error handling when variable_id/realm is unavailable Better error handling when variable_id/realm is unavailable Nov 25, 2024
@Ciheim
Copy link
Contributor Author

Ciheim commented Nov 25, 2024

#95

ceblanton
ceblanton approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This clearly improves the error message and tests pass.

@ceblanton ceblanton merged commit b3a0814 into main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceblanton ceblanton ceblanton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ciheim @ceblanton