Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdtf support #25

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Conversation

aradhakrishnanGFDL
Copy link
Collaborator

This branch has support for the new MDTF pre-processor.

time_range populated,
standard_name filled in with mappings,
gfdl to cmip frequencies conversion done
CI tests updated, see manifest in actions workflow and download the csv to see how it looks.

@aradhakrishnanGFDL
Copy link
Collaborator Author

@ceblanton I expect the other PR to have merge conflicts once we merge this in though not too much to handle. So, either order for the two open PRs would be ok.. but mdtf support is a simpler PR with no fre-cli implications, and might make sense to merge in first.
Both are pretty exciting and useful.

@aradhakrishnanGFDL
Copy link
Collaborator Author

addresses #23
Part of #2
Part of #22
#20

Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, also looks fine

@aradhakrishnanGFDL aradhakrishnanGFDL merged commit bcb2d17 into NOAA-GFDL:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants