16 pythoncalls #24
Merged
16 pythoncalls #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli and no cli decorated functions, so a function is directly callable as a python function from a standalone py script
|
This will allow analysis-scripts repository to have a nicer interface to catalogbuilder for testing |
|
@ceblanton context - this helps us change this https://github.com/NOAA-GFDL/analysis-scripts/blob/main/tests/test_freanalysis_clouds.py#L49 and do something like https://github.com/aradhakrishnanGFDL/forkCatalogBuilder-/blob/16-pythoncalls/catalogbuilder/scripts/gen_intake_gfdl_runner.py#L10 @menzel-gfdl keeping you in the loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #16
summary of changes
1- Capability to use catalog builder in a cleaner way from notebook and .py
2- Updated examples in scripts/
3- Added new pytests cases to test this functionality
4- Added additional CI workflow to test a locally built conda package (this may need a different approach later, but works well for me)
note - fre-cli needs an update to use create_catalog rather than main
see example here https://github.com/aradhakrishnanGFDL/forkCatalogBuilder-/blob/16-pythoncalls/catalogbuilder/scripts/gen_intake_gfdl_runner.py#L10