Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use non-glorys names in boundary tools #124

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

uwagura
Copy link
Collaborator

@uwagura uwagura commented Dec 9, 2024

Addresses #123 . This PR adds the a list of output files names to the boundary tool yaml so that you can specify names for the concatenated output other than the glorys variable names

@uwagura uwagura requested a review from yichengt900 December 9, 2024 21:44
@yichengt900
Copy link
Contributor

@uwagura, thank you for opening this PR. I believe it is sufficient to include options only for write_glorys_boundary.py, as the OBC files for OBGC contain numerous variables. and it is preferable to maintain consistency by using the same names as those used in the bgc model.

Copy link
Contributor

@yichengt900 yichengt900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uwagura, thank you for the prompt action. The changes look good, and I have tested them on PPAN. I can confirm that the script renames the OBC files as specified by the user. Approved.

@yichengt900 yichengt900 merged commit 50de3f0 into main Dec 11, 2024
3 checks passed
@yichengt900 yichengt900 deleted the feature/issue-123-naming-conventions branch December 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants