Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move get_*.sh files to new "wmo_scripts" directory #236

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

Fixes #210

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review August 21, 2024 18:58
Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test these? If so, how?

@AlysonStahl-NOAA
Copy link
Collaborator Author

Not in a rigorous capacity. I ran a few scripts to check that a file was being rewritten under the correct path.

@edwardhartnett
Copy link
Contributor

What's the failing test all about?

@AlysonStahl-NOAA
Copy link
Collaborator Author

It has nothing to do with this particular PR. I believe it's another test that is passing inconsistently. Not sure if its for the same reason as the ones in #175, but it appears to be a difference in precision / calculation result. I just ran it again and it passes just fine.

@edwardhartnett edwardhartnett merged commit 7e6ffd7 into NOAA-EMC:develop Aug 23, 2024
9 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_wmo branch October 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move get_*.sh scripts to top-level subdirectory "wmo_scripts"
2 participants