Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-sci] Extends bufrsnd job to 84 h #562

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[dev-sci] Extends bufrsnd job to 84 h #562

merged 2 commits into from
Dec 2, 2024

Conversation

MatthewPyle-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • Makes bufrsnd script changes that hopefully extend bufrsnd processing to cover 84 h.

TESTS CONDUCTED:

  • Not tested, but could try a local change in RT RRFS tomorrow if desired.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

ShunLiu-NOAA
ShunLiu-NOAA approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ShunLiu-NOAA ShunLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MatthewPyle-NOAA
Copy link
Contributor Author

Will test it in the 12Z cycle today before merging.

BenjaminBlake-NOAA
BenjaminBlake-NOAA approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending a successful test.

@MatthewPyle-NOAA
Copy link
Contributor Author

BUFR products got processed to 84 h in the 12Z cycle, so will merge.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit dd300ec into NOAA-EMC:dev-sci Dec 2, 2024
1 check passed
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title Extends bufrsnd job to 84 h [dev-sci] Extends bufrsnd job to 84 h Dec 2, 2024
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/bufrsnd84 branch December 2, 2024 19:51
@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this pull request Dec 2, 2024
Closed
MatthewPyle-NOAA added a commit to MatthewPyle-NOAA/rrfs-workflow that referenced this pull request Dec 2, 2024
@MatthewPyle-NOAA
Adds changes from NOAA-EMC#562 and NOAA-EMC#564 in dev-sci into main.
8391490
@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this pull request Dec 2, 2024
Merged
17 tasks
MatthewPyle-NOAA added a commit that referenced this pull request Dec 2, 2024
@MatthewPyle-NOAA
Adds changes from #562 and #564 in dev-sci into main. (#566)
f7fbcd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBlake-NOAA BenjaminBlake-NOAA BenjaminBlake-NOAA approved these changes

@ShunLiu-NOAA ShunLiu-NOAA ShunLiu-NOAA approved these changes

@JacobCarley-NOAA JacobCarley-NOAA Awaiting requested review from JacobCarley-NOAA JacobCarley-NOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewPyle-NOAA @ShunLiu-NOAA @BenjaminBlake-NOAA