Add 'rca' variable to noahmpdrv_run interface for CCPP/physics PR#205 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uturuncoglu @barlage Could one of you please review this PR? |
|
@DeniseWorthen I believe there is some additional testing being performed within ccpp-physics |
|
Hi Mike and Denise,
Yes, I need to test further the rca output in the other PR by @grantfirl.
Patrick
…On Mon, May 13, 2024, 5:03 PM Michael Barlage ***@***.***> wrote:
@DeniseWorthen <https://github.com/DeniseWorthen> I believe there is some
additional testing being performed within ccpp-physics
<ufs-community/ccpp-physics#205 (comment)>
@grantfirl <https://github.com/grantfirl> @uturuncoglu
<https://github.com/uturuncoglu> @drnimbusrain
<https://github.com/drnimbusrain>
—
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNQZB75OH3SHGLE7ME3ZCETBZAVCNFSM6AAAAABHPHOGQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYG44TKNJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@drnimbusrain @DeniseWorthen @barlage @uturuncoglu This has been updated to reflect the latest changes from @drnimbusrain. I believe that it is ready for final review at this point. |
uturuncoglu
approved these changes
May 15, 2024
|
@grantfirl are the noahmpdrv updates in ccpp-physics 205 ready to go for this PR also? |
|
@grantfirl sorry, I think I see the parameter limit changes now |
Yep, the changes here should be identical to ufs-community/ccpp-physics#205 |
barlage
approved these changes
May 16, 2024
|
Tests are done ok at ufs-community/ufs-weather-model#2264. We can merge this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ufs-community/ufs-weather-model#2264 and ufs-community/ccpp-physics#205
Add
rcavariable to NUOPC cap fornoahmpdrv_run().