-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policies toward coupling and absorb policies into GDAS/atmosphere #7
Conversation
* develop: Coding norms Update GDAS hash Remove the prints add get_submod_path Observers subkey not used in the UFO filter test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
* develop: move sub modules to develop
g-w PR #2665 removes |
@RussTreadon-NOAA after jcb moves to GDASapp we can take the change in this PR but into GDASapp. |
* feature/no_sub_mods: action debugging action debugging pyyaml coding norms update README refresh testing use ref update ignore remove submodules
- Rename the atmosphere YAML files to be `atmosphere_<class>.yaml.j2` - Change all the keys associated with the atmosphere to be `{{atmosphere_<key>}}` - Add the marine YAML files. --------- Co-authored-by: danholdaway <[email protected]> Co-authored-by: RussTreadon-NOAA <[email protected]>
@CoryMartin-NOAA , I am rerunning the failed JCB tests for various python versions because the first round of tests failed after hitting what appears to be a wall clock limit. The current round of tests appears similarly stuck. I'll let 'em run but I suspect I'll get multiple fails again. If this happens, any suggestions as to how to work around this? |
@RussTreadon-NOAA do you have a log file or something I can look at? I would think anything related to JCB should finish very quickly, so something strange must be going on. |
@RussTreadon-NOAA or are you talking about the GitHub actions? |
Yes, @CoryMartin-NOAA, I am referring to the github actions. They appear to be hung. This is what happened on the previous run. |
@CoryMartin-NOAA: Yes, I see the same Merge without waiting checkbox. I am reluctant to bypass protections since I am not sure if the failed tests indicated a problem with the PR (not acceptable) or something strange with actions (acceptable). |
It seems like it is a GitHub actions issue. Can we maybe try running JCB ctests on HPC using this branch? (I've never done this before) |
I manually checked out this branch on Hera, ran the commands in the CI, and all 23 tests pass. I'm going to merge and if this comes up again, we will identify and fix why the GitHub Actions are timing out. |
In this PR we add more testing and policies ahead of adding more non-atm components to the client (gdas). The new policies are:
model
,observations
,observation_chronicle
andalgorithm
. No directories are allowed outside of those names.apps/<client>/model/<component>
should begin with component. I.e. instead ofgeometry.yaml
they should beatmosphere_geoemtry.yaml
. This makes sure that there are no duplicate YAML files between e.g. atmosphere and marine, which could cause problems down the road in a coupling world.apps/<client>/model/<component>
should use template keys that are unique to that component, enforced by the keys having to take the form{{<component>_key}}
.These policies are mostly designed to alleviate potential problems associated with having several model components in the same config file, for example when coupling. The policies are set now, despite not being needed in the immediate because it's much easier to do so now. Policies can always be revisited later if needed.
Companion PRs in jcb-gdas and jib-algorithms: