Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get snow 2DVar for deterministic and ensemble mean working #52

Merged
merged 22 commits into from
Dec 12, 2024

Conversation

CoryMartin-NOAA
Copy link
Contributor

Changes to JCB templates to allow for 2DVar snow analyses for the deterministic and the ensemble mean for GDAS.

observations/snow/ghcn_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/ims_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/sfcsno.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/snocvr_snow.yaml.j2 Outdated Show resolved Hide resolved
algorithm/snow/fv3jedi_snow_ensmean.yaml.j2 Outdated Show resolved Hide resolved
algorithm/snow/fv3jedi_snow_ensmean.yaml.j2 Outdated Show resolved Hide resolved
model/snow/snow_3dvar_outer_loop_1.yaml.j2 Outdated Show resolved Hide resolved
model/snow/snow_background.yaml.j2 Outdated Show resolved Hide resolved
model/snow/snow_final_increment_fms.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/adpsfc_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/sfcsno.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/snocvr_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/ghcn_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/adpsfc_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/ghcn_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/sfcsno.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/snocvr_snow.yaml.j2 Outdated Show resolved Hide resolved
observations/snow/ghcn_snow.yaml.j2 Outdated Show resolved Hide resolved
@CoryMartin-NOAA
Copy link
Contributor Author

@yuanxue2870 @jiaruidong2017 I think this is illustrating how important it is that we keep the offline and GFS workflow YAMLs in sync. Are there any other changes that need to be made? If so, do we need to discuss tomorrow?

@yuanxue2870
Copy link
Contributor

@yuanxue2870 @jiaruidong2017 I think this is illustrating how important it is that we keep the offline and GFS workflow YAMLs in sync. Are there any other changes that need to be made? If so, do we need to discuss tomorrow?

Yes, I would suggest an in-person discussion tomorrow. Since GTS and MADIS yamls will both require another round of changes (e.g., new reject list), all changes we made here are likely not being finalized. But at this stage, I think it is always good to keep uncoupled/coupled model runs (esp. yaml files) in sync (if the observation files and their attributes are identical between these two modes) - I guess this is also one of the reasons Clara wants to introduce JCB into the process to avoid asynchronous changes. Just my two cents.

@jiaruidong2017
Copy link
Contributor

@yuanxue2870 @jiaruidong2017 I think this is illustrating how important it is that we keep the offline and GFS workflow YAMLs in sync. Are there any other changes that need to be made? If so, do we need to discuss tomorrow?

It is good for me now, and I will show some tests for the latest changes in our tomorrow's meeting.

@jiaruidong2017
Copy link
Contributor

@yuanxue2870 @jiaruidong2017 I think this is illustrating how important it is that we keep the offline and GFS workflow YAMLs in sync. Are there any other changes that need to be made? If so, do we need to discuss tomorrow?

Yes, I would suggest an in-person discussion tomorrow. Since GTS and MADIS yamls will both require another round of changes (e.g., new reject list), all changes we made here are likely not being finalized. But at this stage, I think it is always good to keep uncoupled/coupled model runs (esp. yaml files) in sync (if the observation files and their attributes are identical between these two modes) - I guess this is also one of the reasons Clara wants to introduce JCB into the process to avoid asynchronous changes. Just my two cents.

I think the new rejectlist is beyond of this PR, because it requires more efforts. We can update the rejectlist later when it is ready.

Copy link
Contributor

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your great efforts.

Copy link

@ClaraDraper-NOAA ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Later, we can update the configurations.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 5a468be into develop Dec 12, 2024
1 check passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/snow-2dvar branch December 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants