-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to get snow 2DVar for deterministic and ensemble mean working #52
Conversation
…gdas into feature/snow-2dvar
@yuanxue2870 @jiaruidong2017 I think this is illustrating how important it is that we keep the offline and GFS workflow YAMLs in sync. Are there any other changes that need to be made? If so, do we need to discuss tomorrow? |
Yes, I would suggest an in-person discussion tomorrow. Since GTS and MADIS yamls will both require another round of changes (e.g., new reject list), all changes we made here are likely not being finalized. But at this stage, I think it is always good to keep uncoupled/coupled model runs (esp. yaml files) in sync (if the observation files and their attributes are identical between these two modes) - I guess this is also one of the reasons Clara wants to introduce JCB into the process to avoid asynchronous changes. Just my two cents. |
It is good for me now, and I will show some tests for the latest changes in our tomorrow's meeting. |
I think the new rejectlist is beyond of this PR, because it requires more efforts. We can update the rejectlist later when it is ready. |
Co-authored-by: Jiarui Dong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for your great efforts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Later, we can update the configurations.
Co-authored-by: yuanxue2870 <[email protected]>
Changes to JCB templates to allow for 2DVar snow analyses for the deterministic and the ensemble mean for GDAS.