replace fixed distribution name with templated variable #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TravisElless-NOAA and @SamuelDegelia-NOAA , this PR replaces the hardwired with a templated variable This change is made to all templates in If either of you have time, can you review these changes? |
7 tasks
SamuelDegelia-NOAA
approved these changes
Aug 15, 2024
|
Thanks @SamuelDegelia-NOAA for the review and approval! |
TravisElless-NOAA
approved these changes
Aug 15, 2024
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Aug 20, 2024
This PR adds prototype templates to run the lgetkf in observation and solver modes. Doing so necessitates updates to `parm/jcb-algorithms` and `parm/jcb-gdas`. The PR also changes the `iodafile` in `ush/ioda/bufr2ioda/bufr2ioda_acft_profiles_prepbufr.py` to be consistent with the `jcb-gdas` template. Resolves #1249 Dependencies - jcb-algorithms PR [#4](NOAA-EMC/jcb-algorithms#4) - jcb-gdas PR [#23](NOAA-EMC/jcb-gdas#23) **DO NOT MERGE THIS PR into GDASApp `develop` until** 1. the above jcb PRs are merged into their respective `develop` 2. the jcb hashes in this PR are updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lgetkf observer and solver steps use different distribution types. Observer runs use
RoundRobin. Solver runs useHalo. This PR replaces the currently fixed distribution type,Halo, inobservations/atmosphere-lgetkf/templates with variabledistribution_type. This allows the distribution type to be set at runtime.Resolves #22