Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a gefs_arch task to GEFS workflow #3211

Merged

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Jan 7, 2025

Description

  • The gefs_arch task is not generated during the execution of the workflow setup scripts. It is only created when do_extractvars is set to true, with do_extractvars being false by default. This pull request ensures that the gefs_arch task will be created in the workflow regardless of the value of do_extractvars.

    Resolves The GEFS workflow does not create a gefs_arch task #3151

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)

How has this been tested?

  • CI test on HERCULES and HERA

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@WalterKolczynski-NOAA
Copy link
Contributor

It's coming back to me why we only had the archive task when extract_vars is on: the archive job doesn't do much for GEFS right now when extract_vars is off (well, now it may archive the expdir). If you look at parm/archive/master_gefs.yaml.j2, all of the non-expdir included lists are extracted ones. There is a parm/archive/gefs_arcdir.yaml.j2, but it doesn't seem to be included anywhere.

I think to complete this, we need the following:

  • The inclusion of the extracted files need to be hidden behind the DO_EXTRACTVARS flag (it should be failing right now if it is off)
  • The gefs_arcdir file needs to be included when extract vars is off

@DavidHuber-NOAA @EricSinsky-NOAA please let me know if I'm incorrect here.

@DavidHuber-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA Yes, I think you are correct. There would need to be an if-block around

{% filter indent(width=4) %}
{% include "gefs_extracted_atmos.yaml.j2" %}
{% include "gefs_extracted_ocean.yaml.j2" %}
{% include "gefs_extracted_ice.yaml.j2" %}
{% include "gefs_extracted_wave.yaml.j2" %}
{% endfilter %}

@EricSinsky-NOAA
Copy link
Contributor

To make things more simple, I believe we can remove the gefs_extracted* yaml files and only use gefs_arcdir.yaml.j2. The only place these gefs_extracted* yaml files are needed are in the feature/gefs_reforecast branch. I do not believe they are needed in develop if we use gefs_arcdir.yaml.j2.

@AntonMFernando-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA A CI test passed in HERCULES. @EricSinsky-NOAA Are you satisfied with the changes? If so we can go ahead and run CIs in the PR.

Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Thank you, @AntonMFernando-NOAA.

@emcbot emcbot removed the CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress label Jan 16, 2025
@emcbot
Copy link

emcbot commented Jan 16, 2025

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3211/RUNTESTS/EXPDIR/C48_S2SWA_gefs_59fb602b

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 16, 2025
@emcbot
Copy link

emcbot commented Jan 16, 2025

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3211


Experiment C96_S2SWA_gefs_replay_ics_59fb602b Completed 1 Cycles: *SUCCESS* at Thu Jan 16 10:38:46 UTC 2025
Experiment C48mx500_3DVarAOWCDA_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:44:50 UTC 2025
Experiment C48mx500_hybAOWCDA_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:50:55 UTC 2025
Experiment C48_ATM_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:50:56 UTC 2025
Experiment C96C48_hybatmaerosnowDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:04:27 UTC 2025
Experiment C48_S2SWA_gefs_59fb602b Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Thu Jan 16 12:04:54 UTC 2025
Experiment C48_S2SWA_gefs_59fb602b Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3211/RUNTESTS/COMROOT/C48_S2SWA_gefs_59fb602b/logs/2021032312/gefs_arch.log
Experiment C96_atm3DVar_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:10:20 UTC 2025
Experiment C96C48_hybatmDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:10:57 UTC 2025
Experiment C48_S2SW_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 12:28:42 UTC 2025
Experiment C96C48_ufs_hybatmDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:40:55 UTC 2025

@DavidHuber-NOAA
Copy link
Contributor

@AntonMFernando-NOAA the parm/archive/gefs_extractvars* YAMLs should also be deleted. These will only be retained in the gefs_reforecast branch (not develop).

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Will wait for @EricSinsky-NOAA's approval before starting CI testing.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 16, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 16, 2025
@emcbot
Copy link

emcbot commented Jan 16, 2025

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3211


Experiment C48mx500_3DVarAOWCDA_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 18:58:29 UTC 2025
Experiment C48mx500_hybAOWCDA_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 19:04:47 UTC 2025
Experiment C48_ATM_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 19:10:48 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_c1b23a60 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 19:10:49 UTC 2025
Experiment C96C48_hybatmDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:19:12 UTC 2025
Experiment C96_atm3DVar_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:25:34 UTC 2025
Experiment C48_S2SWA_gefs_c1b23a60 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 20:26:22 UTC 2025
Experiment C96C48_hybatmaerosnowDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:31:48 UTC 2025
Experiment C48_S2SW_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 20:57:59 UTC 2025
Experiment C96C48_ufs_hybatmDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 21:11:18 UTC 2025

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 3a5af9a into NOAA-EMC:develop Jan 16, 2025
10 of 11 checks passed
tsga added a commit to tsga/global-workflow that referenced this pull request Jan 22, 2025
* develop:
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Jan 27, 2025
* develop:
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
  Only run METplus in the 3Dvar tests (NOAA-EMC#3245)
  Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106)
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
  Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199)
  Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171)
  Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193)
  Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197)
  Remove early-cycle EnKF forecast (NOAA-EMC#3185)
  Fix mod_icec bug in atmos_prod (NOAA-EMC#3167)
  Create compute build option (NOAA-EMC#3186)
  Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
  Update compression options for high res history files (NOAA-EMC#3178)
  Turn DO_TEST_MODE off (NOAA-EMC#3177)
  Hotfix for gdas_arch div/0 (NOAA-EMC#3169)
  Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098)
  Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125)
  Update ufs-weather-model to 2024-12-06 commit  (NOAA-EMC#3145)
  Enable traditional threading as an option (NOAA-EMC#3149)
  Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164)
  Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120)
  Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092)
  Update HPC Tier Definitions (NOAA-EMC#3138)
  Add marine hybrid envar (NOAA-EMC#3041)
  Archive the experiment directory along with git status/diff output (NOAA-EMC#3105)
  Use stochastic restart patterns on rerun (NOAA-EMC#3077)
  Point Jenkinsfile back to CI/ (NOAA-EMC#3139)
  Fix wave restart for cold start and add ic version file (NOAA-EMC#3112)
  Allow users to override the default account at setup time (NOAA-EMC#3127)
  Refactor gridded wave post (NOAA-EMC#3014)
  Update docs related to NOAA CSPs (NOAA-EMC#3043)
  Allow APP to differ between RUNs (NOAA-EMC#2943)
  Run one executable for soca2cice (instead of two) (NOAA-EMC#3118)
  Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115)
  Make aerosol output frequency variable (NOAA-EMC#2982)
  Add new stations to GFS BUFR sounding products (NOAA-EMC#3107)
  JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992)
  Enable tapering of atm ens perts at the model top (NOAA-EMC#3097)
  Update JGDAS ENKF POST  job  (NOAA-EMC#3090)
  SFS Runs at C96mx100  (NOAA-EMC#2960)
  Move machine-based options from config.base to host files (NOAA-EMC#3053)
  Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076)
  CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084)
  Update JGDAS ENKF ECEN job  (NOAA-EMC#3050)
  Update snow obs processing job (NOAA-EMC#3055)
  Update to action workflow pipeline in default repo for development  (NOAA-EMC#3062)
  Update to action workflow pipeline in default repo for development (NOAA-EMC#3061)
  Update workflow pipeline (NOAA-EMC#3060)
  PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059)
  Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057)
  GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056)
  Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995)
  Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051)
  Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030)
  Make wxflow links static instead of from link_workflow (NOAA-EMC#3008)
  Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959)
  Add run and finalize methods to marine LETKF task (NOAA-EMC#2944)
  Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009)
  Disabling hyper-threading (NOAA-EMC#2965)
  GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018)
  CI jekninsfile update hotfix (NOAA-EMC#3038)
  Update gdas.cd (NOAA-EMC#2978)
  Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036)
  CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013)
  Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033)
  Document the generate_workflows.sh script (NOAA-EMC#3028)
  Replace gfs_cyc with an interval (NOAA-EMC#2928)
  Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024)
  Add a tool to run multiple YAML cases locally (NOAA-EMC#3004)
  Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The GEFS workflow does not create a gefs_arch task
5 participants