Update JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs with COMIN/COMOUT instead of COM

[mingshichen-noaa]

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs.

Refs #2451

Type of change

• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

• Clone and build on RDHPCS
• Cycled tests on Hercules
• Forecast-only tests on Hercules

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• I have made corresponding changes to the documentation if necessar

[KateFriedman-NOAA]

@mingshichen-noaa FYI, please ignore CI test messages in your PR. We are using your PR to test a new CI setup on WCOSS2. We will rerun the CI tests for this PR once reviews have completed. Thanks!

[KateFriedman-NOAA]

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3170/RUNTESTS on WCOSS

[mingshichen-noaa]

@KateFriedman-NOAA
I stopped CI test on Hercules.

[KateFriedman-NOAA]

I stopped CI test on Hercules.

@mingshichen-noaa CI tests that you were running under your account? Why did you stop them? Was there an error?

[mingshichen-noaa]

I stopped CI test on Hercules.

@mingshichen-noaa CI tests that you were running under your account? Why did you stop them? Was there an error?

[mingshichen-noaa]

@KateFriedman-NOAA
After I checked the running status with rocotostat and found all running states with SUCCEEDED in cycle from 202112201800 to 202112210600, I stopped the crontab running.

[mingshichen-noaa]

@WalterKolczynski-NOAA

[mingshichen-noaa]

@WalterKolczynski-NOAA
In order to resolve the above-mentioned conflicting files: sorc/gdas.cd sorc/gfs_utils.fd, I remembered you ever told me the following resolved method:
"you should have run git submodule update --init --recursive to update the submodules locally. Now, you need to check out the correct versions from develop and commit them (or rebase interactively to remove the offending commits, but that is a bit advanced). "
I forgot how to get the correct versions of the two directories from develop. Will you be available tomorrow to make google chat?

[WalterKolczynski-NOAA]

@mingshichen-noaa For each submodule you've inadvertently modified:

1. Look up the correct hash from develop

cd sorc/<submodule>
git checkout <hash>
cd ..
git add <submodule>
# repeat for all submodules
git commit

[WalterKolczynski-NOAA]

This is still not the correct hash for ufs_model:

[WalterKolczynski-NOAA]

@mingshichen-noaa There haven't been any updates to this PR in a week. Some submodule hashes are still incorrect. This should have been a pretty quick fix. What's the hold-up?

[github-advanced-security]

ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[mingshichen-noaa]

@KateFriedman-NOAA
On Tuesday Rahul made a google chat with me to figure out the issue but not done. These days I have tried to figure out submodule issues in PR (#3170), based on your suggestion and Kate's instruction and some solution suggestions from google. Right now I am taking CI test in Hercules. I expect to resolve the issue as soon as possible.