Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate csawMG update #782

Closed
wants to merge 1 commit into from

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Feb 12, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
incorporate csawMG update and pass both intel and GNU RT tests. All CSAW related tests need new baselines.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
tested in hera
What compilers / HPCs was it tested with?
both intel and GNU compilerss
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
yes
Have the ufs-weather-model regression test been run? On what platform?
run in hera

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • all csawMG runs needs new baselines
  • Please commit the regression test log files in your ufs-weather-model branch
  • done

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@DusanJovic-NOAA DusanJovic-NOAA changed the title incorporate csawMG update and pass both intel and GNU RT tests Incorporate csawMG update and pass both intel and GNU RT tests Feb 23, 2024
@DusanJovic-NOAA DusanJovic-NOAA changed the title Incorporate csawMG update and pass both intel and GNU RT tests Incorporate csawMG update Feb 23, 2024
@grantfirl
Copy link
Collaborator

@jkbk2004 This can be closed since #795 replaces it.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 8, 2024

closed to follow with #795

@jkbk2004 jkbk2004 closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants