Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the MPAS model to the latest gsl/develop version v8.2.2-2.6 #265

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

update the MPAS model to the latest gsl/develop version v8.2.2-2.6 #265

wants to merge 6 commits into from

Conversation

guoqing-noaa
Copy link
Collaborator

The rrfs-workflow needs the latest GSL MPAS version to run JEDIVAR correctly.

@rrfsbot
Copy link
Collaborator

rrfsbot commented Jan 30, 2025

FAILED on jet

started build_and_test on jet at UTC time: Thu Jan 30 17:16:44 UTC 2025
finished at UTC time: Thu Jan 30 17:21:19 UTC 2025

workdir: /lfs5/BMC/wrfruc/rrfsbot/PRs_RDASApp/265

@delippi
Copy link
Collaborator

delippi commented Jan 30, 2025

@guoqing-noaa, is there a particular reason we need a separate fork of the MPAS-model? Would it be possible to incorporate the updates directly into the MPAS-Dev/MPAS-Model repo and then sync the submodule from there?

@guoqing-noaa
Copy link
Collaborator Author

@guoqing-noaa, is there a particular reason we need a separate fork of the MPAS-model? Would it be possible to incorporate the updates directly into the MPAS-Dev/MPAS-Model repo and then sync the submodule from there?

@delippi Good question! The GSL model group is in discussion with NCAR about committing back to the authoritative repo on a regular basis. But it looks like there are still quite a few challenges there. New model updates are not able to be merged into the authoritative repo in time. The GSL physics schemes in MPAS are still in a rapid evolution process. If there is a model problem, we will rely upon the model group to resolve it. So it is a safe bet to track the NOAA-GSL repo.
I will check with the model group again to see what's the current status of committing back to the authoritative repo and update here if I have any new information. Thanks!

@guoqing-noaa guoqing-noaa marked this pull request as draft January 30, 2025 17:44
@guoqing-noaa
Copy link
Collaborator Author

Convert to draft while debugging on the compiling issue.

@delippi
Copy link
Collaborator

delippi commented Jan 30, 2025

@guoqing-noaa, is there a particular reason we need a separate fork of the MPAS-model? Would it be possible to incorporate the updates directly into the MPAS-Dev/MPAS-Model repo and then sync the submodule from there?

@delippi Good question! The GSL model group is in discussion with NCAR about committing back to the authoritative repo on a regular basis. But it looks like there are still quite a few challenges there. New model updates are not able to be merged into the authoritative repo in time. The GSL physics schemes in MPAS are still in a rapid evolution process. If there is a model problem, we will rely upon the model group to resolve it. So it is a safe bet to track the NOAA-GSL repo. I will check with the model group again to see what's the current status of committing back to the authoritative repo and update here if I have any new information. Thanks!

That makes sense. Thanks for the clarification! I think it is fine as long as there is always talk (and action) about committing back to the authoritative repo. We definitely don't want things to diverge too much.

@guoqing-noaa
Copy link
Collaborator Author

PR to the MPAS-Model:
NOAA-GSL/MPAS-Model#90

@guoqing-noaa
Copy link
Collaborator Author

NOAA-GSL/MPAS-Model#90 has been merged.

@guoqing-noaa guoqing-noaa marked this pull request as ready for review February 12, 2025 20:07
@guoqing-noaa guoqing-noaa changed the title update the MPAS model to the latest gsl/develop branch update the MPAS model to the latest gsl/develop version v8.2.2-2.6 Feb 12, 2025
@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 12, 2025

FAILED on jet

started build_and_test on jet at UTC time: Wed Feb 12 20:11:39 UTC 2025
finished at UTC time: Wed Feb 12 20:22:42 UTC 2025

workdir: /lfs5/BMC/wrfruc/rrfsbot/PRs_RDASApp/265

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 12, 2025

FAILED on hera

started build_and_test on hera at UTC time: Wed Feb 12 22:28:36 UTC 2025
finished at UTC time: Wed Feb 12 22:28:44 UTC 2025

workdir: /scratch1/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/265

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 12, 2025

PASSED on jet

started build_and_test on jet at UTC time: Wed Feb 12 22:37:04 UTC 2025
finished at UTC time: Wed Feb 12 23:33:55 UTC 2025

Test project /lfs5/BMC/wrfruc/rrfsbot/PRs_RDASApp/265/build/rrfs-test
    Start 2: rrfs_fv3jedi_2024052700_getkf_observer
    Start 5: rrfs_mpasjedi_2024052700_getkf_observer
    Start 1: rrfs_fv3jedi_2024052700_Ens3Dvar
    Start 4: rrfs_mpasjedi_2024052700_Ens3Dvar
    Start 7: rrfs_mpasjedi_2024052700_bumploc
    Start 8: rrfs_bufr2ioda_msonet
1/8 Test #8: rrfs_bufr2ioda_msonet .....................   Passed   57.72 sec
2/8 Test #5: rrfs_mpasjedi_2024052700_getkf_observer ...   Passed  291.14 sec
    Start 6: rrfs_mpasjedi_2024052700_getkf_solver
3/8 Test #7: rrfs_mpasjedi_2024052700_bumploc ..........   Passed  420.54 sec
4/8 Test #2: rrfs_fv3jedi_2024052700_getkf_observer ....   Passed  434.08 sec
    Start 3: rrfs_fv3jedi_2024052700_getkf_solver
5/8 Test #4: rrfs_mpasjedi_2024052700_Ens3Dvar .........   Passed  469.02 sec
6/8 Test #1: rrfs_fv3jedi_2024052700_Ens3Dvar ..........   Passed  485.05 sec
7/8 Test #3: rrfs_fv3jedi_2024052700_getkf_solver ......   Passed  655.76 sec
8/8 Test #6: rrfs_mpasjedi_2024052700_getkf_solver .....   Passed  1125.92 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi            = 3939.23 sec*proc (8 tests)
rdas-bundle    = 3939.23 sec*proc (8 tests)
script         = 3939.23 sec*proc (8 tests)

Total Test time (real) = 1417.48 sec

workdir: /lfs5/BMC/wrfruc/rrfsbot/PRs_RDASApp/265

@guoqing-noaa
Copy link
Collaborator Author

@ShunLiu-NOAA @delippi @SamuelDegelia-NOAA @TingLei-NOAA
This PR passed the tests and is now ready for review. Thanks!

guoqing-noaa
guoqing-noaa commented Feb 12, 2025
View reviewed changes
build.sh
@@ -92,6 +92,9 @@ case ${BUILD_TARGET} in
;;
esac

# tweak sorc/mpas/src/core_init_atmosphere/mpas_init_atm_cases.F to make building work
sed -i -e "5549 s/.*/call mpas_log_write('Interpolating SOILM000')/" sorc/mpas/src/core_init_atmosphere/mpas_init_atm_cases.F

Copy link
Collaborator Author

@guoqing-noaa guoqing-noaa Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this tweak is documented by this issue: NOAA-GSL/MPAS-Model#93

Currently, we don't know what is a good way to move forward with this on the MPAS-Model side.

The standard alone CMake can build MPAS-Model, but RDASApp complains about line 5549 of the 'mpas_init_atm_cases.F" file. I don't have time to debug this for the moment. But we cannot wait and need to move forward on using the GSL MPAS for RDASApp.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should bring this to RRFS developer meeting. It is a weird change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShunLiu-NOAA That's a good idea! Hope that will elevate the priorities for this issue. Thanks!

@delippi
Copy link
Collaborator

delippi commented Feb 13, 2025

Can we make sure it passes on hera too? After that I think this will be good to go.

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 13, 2025

PASSED on hera

started build_and_test on hera at UTC time: Thu Feb 13 19:55:59 UTC 2025
finished at UTC time: Thu Feb 13 20:50:19 UTC 2025

Test project /scratch1/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/265/build/rrfs-test
    Start 2: rrfs_fv3jedi_2024052700_getkf_observer
    Start 5: rrfs_mpasjedi_2024052700_getkf_observer
    Start 1: rrfs_fv3jedi_2024052700_Ens3Dvar
    Start 4: rrfs_mpasjedi_2024052700_Ens3Dvar
    Start 7: rrfs_mpasjedi_2024052700_bumploc
    Start 8: rrfs_bufr2ioda_msonet
1/8 Test #8: rrfs_bufr2ioda_msonet .....................   Passed   32.38 sec
2/8 Test #5: rrfs_mpasjedi_2024052700_getkf_observer ...   Passed  273.65 sec
    Start 6: rrfs_mpasjedi_2024052700_getkf_solver
3/8 Test #2: rrfs_fv3jedi_2024052700_getkf_observer ....   Passed  276.88 sec
    Start 3: rrfs_fv3jedi_2024052700_getkf_solver
4/8 Test #7: rrfs_mpasjedi_2024052700_bumploc ..........   Passed  319.68 sec
5/8 Test #1: rrfs_fv3jedi_2024052700_Ens3Dvar ..........   Passed  344.93 sec
6/8 Test #4: rrfs_mpasjedi_2024052700_Ens3Dvar .........   Passed  456.86 sec
7/8 Test #3: rrfs_fv3jedi_2024052700_getkf_solver ......   Passed  579.18 sec
8/8 Test #6: rrfs_mpasjedi_2024052700_getkf_solver .....   Passed  978.59 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi            = 3262.15 sec*proc (8 tests)
rdas-bundle    = 3262.15 sec*proc (8 tests)
script         = 3262.15 sec*proc (8 tests)

Total Test time (real) = 1252.30 sec

workdir: /scratch1/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShunLiu-NOAA ShunLiu-NOAA Awaiting requested review from ShunLiu-NOAA

@SamuelDegelia-NOAA SamuelDegelia-NOAA Awaiting requested review from SamuelDegelia-NOAA

@delippi delippi Awaiting requested review from delippi

@TingLei-NOAA TingLei-NOAA Awaiting requested review from TingLei-NOAA

@Junjun-NOAA Junjun-NOAA Awaiting requested review from Junjun-NOAA

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Passed_hera Passed_jet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guoqing-noaa @rrfsbot @delippi @ShunLiu-NOAA