Phase 3 validation: updates for msonet yamls #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delippi
requested review from
hu5970,
ShunLiu-NOAA,
guoqing-noaa,
spanNOAA and
SamuelDegelia-NOAA
ShunLiu-NOAA
approved these changes
Dec 16, 2024
|
@hu5970 @guoqing-noaa or @spanNOAA do you have a chance to review this PR? |
spanNOAA
approved these changes
Jan 2, 2025
hu5970
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finished Phase 3 testing with great results. Since such extensive testing is done during Phase 2, there is little if any that needs to be done for Phase 3. All of these updates are related to using the updated GSI case (which more accurately reflects the RRFSv1 configuration) or were formatting or improved comments. Phase 3 results start in the associated issue with this #80 (comment)
For future: It would be nice to be able to read the info from convinfo instead of hard coding them into each yaml. I bet that capability is part of JCB.
Issue(s) addressed
Checklist