Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pds templates to current WMO values #561

Merged
merged 82 commits into from
Dec 24, 2024

Conversation

AlysonStahl-NOAA
Copy link
Contributor

@AlysonStahl-NOAA AlysonStahl-NOAA commented Dec 4, 2024

Part of #563

This PR adds 55 missing Product Definition templates (according to recent documentation). Most of these templates are recent additions (after 8/23/2023), however there were a few still missing from some previous updates. I included them in this update unless they were marked as deprecated.

@AlysonStahl-NOAA
Copy link
Contributor Author

There are 8 more templates (2 from July 2024, 6 from August 2023). However, I may need some guidance on how to handle their extensions.

The extensions for these templates are defined by 2-3 parameters, however, some of these parameters are defined within the extensions themselves.

For example, in this template the extension has two parts and is defined by the parameters NDSP and NFSP. The value for NFSP is defined at the end of the first part where the length is defined by NDSP. I have a similar challenge with the 7 other templates.

I may have missed it, but I can't seem to find any existing template extensions that follow this type of pattern that I would be able to use as an example.

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review December 11, 2024 20:37
@edwardhartnett
Copy link
Contributor

Let's not worry about handling those templates until someone at NOAA actually wants them. THen we will probably have to recode some stuff.

@edwardhartnett edwardhartnett merged commit 8dbbaad into NOAA-EMC:develop Dec 24, 2024
38 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_wmo branch January 2, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants