Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing 0 gridpoints problem #486

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fixing 0 gridpoints problem #486

merged 1 commit into from
Feb 28, 2024

Conversation

edwardhartnett
Copy link
Contributor

Fixes #485

AlexanderRichert-NOAA
AlexanderRichert-NOAA approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever a time where the printed average value should not be the default of 0 if if (sec5_info->num_data_points) resolves to false?
Also I think some compilers/settings would prefer 0.0 over 0 but I could be wrong.

@edwardhartnett
Copy link
Contributor Author

0 is standard fortran so will work.

Basically, if there are 0 data points, 0 will be printed for these values, instead of whatever happens to be in the memory space. This is the same thing I just did to the fortran version of the code.

@edwardhartnett edwardhartnett merged commit 60eb050 into develop Feb 28, 2024
33 checks passed
@edwardhartnett edwardhartnett deleted the ejh_0228 branch February 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

@Hang-Lei-NOAA Hang-Lei-NOAA Awaiting requested review from Hang-Lei-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to better handle degrib2 output for message with 0 data points
2 participants
@edwardhartnett @AlexanderRichert-NOAA