Update for aecunpack.c #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in aecunpack.c where the bytes from the decoded AEC buffer stream are not being properly copied into the ifld array. The AEC stream is byte aligned. This commit references #461
Commenting out ifld1 since the code logic that uses it is commented out. This commit references #461
|
Testing? |
|
The existing tests for AEC compression using very small hardcoded data pass. Do you want a more complex test for AEC compression perhaps using ECMWF data -- 1 GRIB2 message? |
|
Yes, please add more testing, that would be very helpful. Have you looked at the code coverage report for your code? |
|
Re: code coverage. No. How do you do that? |
|
For some reason your code is not appearing on the coverage report. I'm looking into that. Meanwhile, I will merge this PR and we will address more testing in another PR. |
edwardhartnett
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in aecunpack.c where the bytes from the decoded AEC buffer stream are not being properly copied into the ifld array. The AEC stream is byte aligned.
This commit references #461