Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and test negative forecast time bug #456

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix and test negative forecast time bug #456

merged 3 commits into from
Oct 26, 2023

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett
Copy link
Contributor Author

There's more work to do to get the rest of the aqm file working with g2cdegrib2, but this PR adds a test that confirms that the negative forecast bug is fixed in g2c.

@edwardhartnett edwardhartnett marked this pull request as ready for review October 25, 2023 20:53
@edwardhartnett edwardhartnett mentioned this pull request Oct 25, 2023
Closed
@edwardhartnett edwardhartnett merged commit 824efa3 into develop Oct 26, 2023
33 checks passed
@edwardhartnett edwardhartnett deleted the ejh_aqm branch October 26, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not correctly interpreting negative forecast time
2 participants
@edwardhartnett @Hang-Lei-NOAA