Skip to content

Commit

Permalink
pds 4.118
Browse files Browse the repository at this point in the history
  • Loading branch information
AlysonStahl-NOAA committed Dec 6, 2024
1 parent 268da35 commit b4275bb
Showing 3 changed files with 44 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/grib2.h.in
Original file line number Diff line number Diff line change
@@ -291,7 +291,7 @@ g2int g2_gribend(unsigned char *cgrib);
/* Constants to help with templates. */
#define G2C_MAX_GDS_TEMPLATE 31 /**< Maximum number of grid templates. */
#define G2C_MAX_GDS_TEMPLATE_MAPLEN 28 /**< Maximum grid template map length. */
#define G2C_MAX_PDS_TEMPLATE 94 /**< Maximum number of PDS templates. */
#define G2C_MAX_PDS_TEMPLATE 95 /**< Maximum number of PDS templates. */
#define G2C_MAX_PDS_TEMPLATE_MAPLEN 45 /**< Maximum template map length. */
#define G2C_MAX_DRS_TEMPLATE 10 /**< Maximum number of DRS templates. */
#define G2C_MAX_DRS_TEMPLATE_MAPLEN 18 /**< Maximum DRS template map length. */
21 changes: 21 additions & 0 deletions src/pdstemplates.c
Original file line number Diff line number Diff line change
@@ -418,6 +418,10 @@ static const struct pdstemplate templatespds[G2C_MAX_PDS_TEMPLATE] =
4.117: Individual large ensemble forecast, control and perturbed, at a horizontal
level or in a horizontal layer at a point in time */
{117, 18, 0, {1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4}},
/** PDT 4.118 (12/04/2024)
4.118: Individual large ensemble forecast, control and perturbed, at a horizontal
level or in a horizontal layer at a point in time */
{118, 32, 1, {1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4, 2, 1, 1, 1, 1, 1, 1, 4, 1, 1, 1, 4, 1, 4}},
};

/**
@@ -1587,6 +1591,23 @@ extpdstemplate(g2int number, g2int *list)
new->ext[l + 31] = 1;
new->ext[l + 32] = 4;
}
/* PDT 4.118 (12/04/2024) */
else if (number == 118)
{
if (list[24] > 1)
{
new->extlen = (list[24] - 1) * 6;
new->ext = malloc(sizeof(g2int) * new->extlen);
for (j = 2; j <= list[24]; j++)
{
l = (j - 2) * 6;
for (k = 0; k < 6; k++)
{
new->ext[l + k] = new->map[26 + k];
}
}
}
}
return new;
}

28 changes: 22 additions & 6 deletions tests/tst_pdstemplates.c
Original file line number Diff line number Diff line change
@@ -693,29 +693,40 @@ main()
return G2C_ERROR;
free(tmpl->ext);
free(tmpl);

/* Check for one that's there but does need an extension. */
tmpl = extpdstemplate(118, list);
if (!tmpl)
return G2C_ERROR;
if (tmpl->num != 118 || tmpl->maplen != 32 || !tmpl->needext)
return G2C_ERROR;
if (!tmpl->ext)
return G2C_ERROR;
free(tmpl->ext);
free(tmpl);
}
printf("ok!\n");
printf("Testing all getpdstemplate() calls with extensions...\n");
{
#define NUM_TEST 94
#define NUM_TEST 95
int number[NUM_TEST] = {
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 20, 30, 31, 40, 41,
42, 43, 254, 1000, 1001, 1002, 1100, 1101, 32, 44, 45, 46, 47, 48, 50, 52,
51, 91, 33, 34, 53, 54, 57, 60, 61, 35, 49, 55, 58, 59, 62, 63, 67, 68, 70,
71, 72, 73, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 92,
93, 94, 95, 96, 97, 98, 99, 100, 103, 104, 108, 109, 110, 111, 113, 114,
115, 116, 117};
115, 116, 117, 118};
int expected_maplen[NUM_TEST] = {
15, 18, 17, 31, 30, 22, 16, 15, 29, 36, 30, 32, 31, 45, 44, 18, 19, 5, 5,
16, 19, 30, 33, 3, 9, 16, 15, 15, 22, 10, 21, 24, 35, 38, 26, 21, 15, 16,
36, 18, 32, 19, 22, 7, 24, 38, 6, 29, 21, 7, 24, 35, 38, 7, 7, 19, 21, 32,
34, 17, 20, 31, 34, 27, 30, 36, 40, 39, 38, 17, 31, 24, 20, 34, 27, 27, 30,
28, 31, 31, 34, 14, 17, 20, 23, 20, 23, 34, 37, 7, 7, 7, 7, 18};
28, 31, 31, 34, 14, 17, 20, 23, 20, 23, 34, 37, 7, 7, 7, 7, 18, 32};
int expected_needext[NUM_TEST] = {
0, 0, 0, 1, 1, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0,
0, 0, 0, 0, 1, 0, 0, 1, 1, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 1,
0, 1, 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 1,
1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0};
1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0, 1};
int expected_map[NUM_TEST][48] = {
{1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4}, /* 0 */
{1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 1, 1}, /* 1 */
@@ -811,6 +822,7 @@ main()
{1, 1, 1, 2, 1, 1, 1}, /* 115 */
{1, 1, 1, 2, 1, 1, 1}, /* 116 */
{1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4}, /* 117 */
{1, 1, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4, 2, 1, 1, 1, 1, 1, 1, 4, 1, 1, 1, 4, 1, 4}, /* 118 */
};
int t;
int ext_t = 0;
@@ -852,12 +864,12 @@ main()
if (map[m] != expected_map[t][m])
return G2C_ERROR;

#define NUM_EXT_TEST 56
#define NUM_EXT_TEST 57
int template[G2C_MAX_PDS_TEMPLATE_MAPLEN];
int expected_extlen[NUM_EXT_TEST] = {
2, 2, 6, 6, 6, 6, 6, 8, 8, 10, 10, 6, 6, 10, 6, 6, 12, 8, 2, 8, 2, 2, 30, 6,
10, 20, 6, 6, 31, 34, 6, 6, 6, 6, 6, 6, 6, 6, 6, 11, 6, 11, 11, 11, 11, 11,
11, 11, 5, 5, 6, 6, 18, 32, 21, 35};
11, 11, 5, 5, 6, 6, 18, 32, 21, 35, 6};
int expected_ext[NUM_EXT_TEST][48] = {
{1, 1}, /* 3 */
{1, 1}, /* 4 */
@@ -915,6 +927,7 @@ main()
{1, 1, 1, 1, 16, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 2, 1, 1, 1, 1, 1, 1, 4, 1, 1, 1, 4, 1, 4}, /* 114 */
{1, 1, 1, 1, 16, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4}, /* 115 */
{1, 1, 1, 1, 16, 1, 1, 1, 2, 1, 1, -4, 1, -1, -4, 1, -1, -4, 1, 4, 4, 2, 1, 1, 1, 1, 1, 1, 4, 1, 1, 1, 4, 1, 4}, /* 116 */
{1, 1, 1, 4, 1, 4}, /* 118 */
};

if (needext)
@@ -1101,6 +1114,9 @@ main()
case 116:
template[6] = 2;
break;
case 118:
template[24] = 2;
break;
default:
return G2C_ERROR;
}

0 comments on commit b4275bb

Please sign in to comment.