Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/public-v2: turn option DEPLOY on by default, update documentation #80

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 26, 2020

This PR

This has been tested on all platforms (with ufs-weather-model as in ufs-community/ufs-weather-model#248) except odin.intel, wcoss_cray, Docker container:

  • cheyenne_gnu
  • cheyenne_intel
  • gaea_intel
  • hera_gnu
  • hera_intel
  • jet_intel
  • macos_clanggfortran
  • macos_gccgfortran
  • redhat_gnu (AWS)
  • orion_intel
  • stampede_intel
  • ubuntu_gnu (AWS)
  • wcoss_dell_p3

@climbfuji climbfuji changed the base branch from develop to release/public-v2 October 28, 2020 17:43
@climbfuji climbfuji marked this pull request as ready for review October 28, 2020 17:49
@RatkoVasic-NOAA
Copy link

I'm testing it on WCOSS-Dell. I had to add two lines for the compilation of the https://github.com/NOAA-EMC/NCEPLIBS-external:
587 18:25 module use /gpfs/dell2/emc/modeling/noscrub/emc.nemspara/soft/modulefiles
588 18:25 module load netcdf_parallel/4.7.4

@climbfuji
Copy link
Collaborator Author

I'm testing it on WCOSS-Dell. I had to add two lines for the compilation of the https://github.com/NOAA-EMC/NCEPLIBS-external:
587 18:25 module use /gpfs/dell2/emc/modeling/noscrub/emc.nemspara/soft/modulefiles
588 18:25 module load netcdf_parallel/4.7.4

Thanks, I'll add them, hopefully correct. Further down, for building the model. You shouldn't (have to) load esmf/8.0.0_ParallelNetCDF, because this is built by NCEPLIBS-external. Can you try that, please?

@RatkoVasic-NOAA
Copy link

I still haven't got to the model. It is failing in NCEPLIBS:
-- Installing NCEPLIBS from /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS/COMPONENTS
-- Installing NCEPLIBS at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1
-- Installing NCEPLIBS modulefiles at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1/modules, NCEPLIBS shell scripts at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1/bin
CMake Error at CMakeLists.txt:259 (find_package):
By not providing "FindNetCDF.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "NetCDF", but
CMake did not find one.

Could not find a package configuration file provided by "NetCDF" with any
of the following names:

NetCDFConfig.cmake
netcdf-config.cmake

Add the installation prefix of "NetCDF" to CMAKE_PREFIX_PATH or set
"NetCDF_DIR" to a directory containing one of the above files. If "NetCDF"
provides a separate development package or SDK, be sure it has been
installed.

@climbfuji
Copy link
Collaborator Author

I still haven't got to the model. It is failing in NCEPLIBS:
-- Installing NCEPLIBS from /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS/COMPONENTS
-- Installing NCEPLIBS at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1
-- Installing NCEPLIBS modulefiles at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1/modules, NCEPLIBS shell scripts at /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS-external-1/bin
CMake Error at CMakeLists.txt:259 (find_package):
By not providing "FindNetCDF.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "NetCDF", but
CMake did not find one.

Could not find a package configuration file provided by "NetCDF" with any
of the following names:

NetCDFConfig.cmake
netcdf-config.cmake

Add the installation prefix of "NetCDF" to CMAKE_PREFIX_PATH or set
"NetCDF_DIR" to a directory containing one of the above files. If "NetCDF"
provides a separate development package or SDK, be sure it has been
installed.

You didn't clone NCEPLIBS with the --recursive option, I suppose. That means the CMakeModules submodule/subdirectory is missing.

@RatkoVasic-NOAA
Copy link

600 18:49 git clone --recursive https://github.com/NOAA-EMC/NCEPLIBS
604 18:49 git branch -a
605 18:49 git chackout release/public-v2

Maybe wrong branch?

@climbfuji
Copy link
Collaborator Author

600 18:49 git clone --recursive https://github.com/NOAA-EMC/NCEPLIBS
604 18:49 git branch -a
605 18:49 git chackout release/public-v2

Maybe wrong branch?

I think this leaves you with the submodules (none) of the develop branch. You need to do

git clone --recursive -b release/public-v2 https://github.com/NOAA-EMC/NCEPLIBS

@RatkoVasic-NOAA
Copy link

RatkoVasic-NOAA commented Oct 28, 2020

will try now
It's compiling
make failed somewhere, I'll start from the beginning.

make[2]: Leaving directory /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS/build' [ 80%] Built target crtm make[1]: Leaving directory /gpfs/dell2/emc/modeling/noscrub/Ratko.Vasic/wrk/tmp/NCEPLIBS-external-1/doc/src/NCEPLIBS/build'
make: *** [all] Error 2

@climbfuji climbfuji force-pushed the deploy_on_update_doc_20201026 branch from 3b9a410 to 8bbabcf Compare October 28, 2020 19:49
@RatkoVasic-NOAA
Copy link

Scanning dependencies of target NEMS.exe
[100%] Building Fortran object CMakeFiles/NEMS.exe.dir/NEMS/src/MAIN_NEMS.F90.o
[100%] Linking Fortran executable NEMS.exe
[100%] Built target NEMS.exe

@climbfuji
Copy link
Collaborator Author

Scanning dependencies of target NEMS.exe
[100%] Building Fortran object CMakeFiles/NEMS.exe.dir/NEMS/src/MAIN_NEMS.F90.o
[100%] Linking Fortran executable NEMS.exe
[100%] Built target NEMS.exe

Great, thanks for that. Where the instructions I sent you by email complete? I need to update the README file in this PR. Thanks!

@climbfuji climbfuji merged commit 95de67f into NOAA-EMC:release/public-v2 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants