Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Feature/ufo geovals up to date. #798

Merged
Merged
Changes from 1 commit
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
e55a937
Regression test updates: global_4dvar bug fix, oom fix, enhance erro…
RussTreadon-NOAA Feb 11, 2023
8857995
GitHub Issue NOAA-EMC/GSI#468 Enhancements to SDL and VDL for simulta…
Wangy1111 Feb 13, 2023
df010e4
Bugfix in EnKF assim of conventional q obs (#545)
ClaraDraper-NOAA Mar 2, 2023
723a034
Update Jet support (#537)
DavidHuber-NOAA Mar 9, 2023
89c4711
gfsda.v16 merge with develop (#526)
emilyhcliu Mar 14, 2023
31b8b29
remove and update non crtm/2.4.0 references (#551)
RussTreadon-NOAA Mar 16, 2023
89ca542
GitHub Issue NOAA-EMC/GSI#538 Add options to tune weights of mixed en…
shoyokota Mar 17, 2023
4afe6ed
Add dDZ for EnKF (#536)
chunhuazhou Mar 24, 2023
113e307
Use prod ncio and ncdiag on wcoss2 (#554)
RussTreadon-NOAA Mar 28, 2023
14ae595
GitHub Issue NOAA-EMC/GSI#539 Add options to tune cross-scale/variabl…
shoyokota Apr 3, 2023
1661c15
Fix write_incr (#559)
jderber-NOAA Apr 14, 2023
48ea34a
Optimize GSI (#527)
jderber-NOAA May 9, 2023
726cc8d
Enhancement to handle hydrometeors in the EnKF I/O interface (#499)
emilyhcliu May 19, 2023
ac1a8cb
Issue with global mean weight for multiscale ensemble runs for ig > 1…
jderber-NOAA May 30, 2023
d766977
GitHub Issue NOAA-EMC/GSI#540 Modify to assimilate radar reflectivity…
shoyokota Jun 1, 2023
57ddc31
Initial changes for GFS v17 soil moisture and temperature analysis (…
ClaraDraper-NOAA Jun 5, 2023
8735959
update fix submodule to bring in gfs.v16.3.7 changes (#581)
RussTreadon-NOAA Jun 6, 2023
00cac54
Feature/enkf q2 (#568)
TingLei-daprediction Jun 27, 2023
333ae16
Zero increments for precipitation hydrometeors are written as missing…
emilyhcliu Jun 28, 2023
accb07e
Bugfix for pseudo_RH option (#602)
ClaraDraper-NOAA Aug 7, 2023
9e5aa09
changes for reanalysis runs (#591)
jack-woollen Aug 8, 2023
be4a3d9
Error in processing VAD winds. (#617)
jderber-NOAA Sep 1, 2023
d7ac706
Gsi fed (#590)
daviddowellNOAA Sep 8, 2023
a6515bd
add missing jacobian arrays to netcdf ozone diagnostic file (#618) (#…
RussTreadon-NOAA Sep 12, 2023
c46f590
Update intel compile to Intel2022 (#571)
hu5970 Sep 12, 2023
008c63c
update fix submodule hash to include gfs.v16.3.9 updates (#621)
RussTreadon-NOAA Sep 14, 2023
d84a18f
Bring in HAFSv1 Related Changes (#608)
JingCheng-NOAA Sep 20, 2023
aa656c6
fix for zero total ozone pressure in EnKF (issue #625) (#626)
jswhit Sep 22, 2023
2f4e7fe
Optimize the reading of ensembles and setup for global multiscale run…
jderber-NOAA Sep 22, 2023
ca19008
Intel 2022 updates (#629)
RussTreadon-NOAA Sep 25, 2023
728d006
Adding code to analyze the siginificant wave heigh in GSI 3D Analysis…
GangZhao-NOAA Sep 29, 2023
ba5a2ca
Refine PM2.5 DA for the RRFS_SD model (#609)
hongli-wang Sep 29, 2023
c56d7bc
GitHub Issue NOAA-EMC/GSI#604 Undefined values found in radar reflect…
shoyokota Sep 30, 2023
fae4bbf
fix a bug in read_obs.F90 missing N21 for EARS and DBnet (#630)
HaidaoLin-NOAA Sep 30, 2023
25306a2
Turn off enspread reg (#635)
ShunLiu-NOAA Oct 4, 2023
978b7e7
A bug fix in setupps (#638)
hu5970 Oct 6, 2023
f76d872
Replacement of float command with real command (#631)
jderber-NOAA Oct 17, 2023
2cb0f5b
Feature/hafs rtcases (#646)
JingCheng-NOAA Oct 27, 2023
acfe56d
Add FED EnVar DA Capability (#632)
hongli-wang Oct 31, 2023
a3e13da
Modified observation errors for radar-reflectivity observations in pr…
daviddowellNOAA Nov 7, 2023
57e45c4
Fix cool layer output
ADCollard Nov 9, 2023
47f35ee
Fix typo in array index used to write SkinLayerCooling to netcdf diag…
ADCollard Nov 20, 2023
1076cf7
Fix bugs with undefined variable and thread safety in intrad.f90 (#659)
shoyokota Nov 28, 2023
c94bc72
Upgrade to spack-stack libraries on non-production machines (#624)
DavidHuber-NOAA Nov 30, 2023
ea667d9
Cads for andrew (#616)
wx20jjung Dec 4, 2023
44a8f59
Dual-resolution EnVar capability for HAFS ensemble (#652)
XuLu-NOAA Dec 5, 2023
2353eaa
Add assimilation of GLM flash-extent density (FED) observations to En…
daviddowellNOAA Dec 7, 2023
275ee0d
restore the line to initialize 'raterr2' as zero (#668)
xyzemc Dec 20, 2023
12a67af
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Dec 21, 2023
336d6fb
Remove HIRS from regression tests
ADCollard Dec 21, 2023
7f37de3
Remove HIRS from GSI regression tests (#672)
ADCollard Jan 18, 2024
12f8d3e
add clipping treatment for negative values of non-negative tracers (#…
AmandaBack-NOAA Jan 24, 2024
8ed034f
Complete issue #607 (Optimization of multiscale regional runs) (#670)
jderber-NOAA Jan 26, 2024
a898668
Updated detect_machine.sh to be consistent with UFSWM. (#691)
HenryRWinterbottom Jan 31, 2024
a59f8ff
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Feb 6, 2024
94c6a7c
Updates for soil moisture and soil temperature analysis (#675)
ClaraDraper-NOAA Feb 7, 2024
2915685
a quick fix for Issue:A indexing out of bounds issue shown in the glo…
TingLei-daprediction Feb 8, 2024
bae0342
Fix soil temperature/mositure read from RRFS warm-start r… (#683)
xyzemc Feb 9, 2024
cd62003
Adding the dry-bulb air temperature and tv flag in the observation di…
GangZhao-NOAA Feb 13, 2024
86ad20e
update fix submodule for GFS v16.3.12 and soil analysis changes (#695)
RussTreadon-NOAA Feb 13, 2024
74ac594
Upgrade the GSI to Spack-Stack version 1.6.0 (#684)
DavidHuber-NOAA Feb 14, 2024
7c4a571
Fix three bugs found in RRFS test (#705)
hu5970 Feb 23, 2024
fca6bea
CrIS viirs bug fix (#708)
wx20jjung Feb 27, 2024
f282a94
Assimilate GMI in GSI (#692)
xincjin-NOAA Mar 12, 2024
a8d670c
Update fix submodule (Rcov_crisn21) & GSI_BINARY_SOURCE_DIR (#718)
RussTreadon-NOAA Mar 14, 2024
8d740a7
Update read_ozone.f90 to handle GOME data before and after 20240131 1…
RussTreadon-NOAA Mar 18, 2024
dfb958f
Update Hera intel modulefile to Rocky 8 (#715)
RussTreadon-NOAA Mar 18, 2024
4e8107c
Add parallel netcdf read/write from EnKF for sfc files (paranc option…
tsga Mar 19, 2024
2167bc9
Issue 694: Upgrade/refactoring for U and V write-out sub for FV3REG G…
TingLei-daprediction Mar 20, 2024
0026f1e
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Mar 22, 2024
f7e93ab
GSI built with debug mode failed in the global_4densvar (#722)
TingLei-NOAA Mar 24, 2024
e1e854d
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Mar 25, 2024
1cc934e
Add the Multigrid Beta Filter (MGBF) for ensemble localization (#699)…
shoyokota Mar 26, 2024
6d9ebbb
Dsfcalc fix (#727)
ADCollard Mar 26, 2024
b53740a
Fix HAFS GSI debug build and run issues (#679)
XuLu-NOAA Mar 27, 2024
b520021
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Mar 27, 2024
b2fc4fd
add ability to taper analysis perts near top of model (#729)
jswhit Mar 29, 2024
db477e3
Update the QC for the enhanced high-resolution GOES-R mesoscale float…
JingCheng-NOAA Apr 1, 2024
29d9d8f
Adding I/O for direct analysis of near-surface wind gust for RRFS-bas…
GangZhao-NOAA Apr 5, 2024
c556875
Merge branch 'NOAA-EMC:develop' into develop
ADCollard Apr 17, 2024
b401c47
Fix minor thinning annoyances. GSI #731
ADCollard Apr 17, 2024
d75f44a
Two small tweaks to thinning (#734)
ADCollard Apr 18, 2024
457510c
reorder correlated error setup checks (#736)
RussTreadon-NOAA Apr 22, 2024
8e279f9
Update Jet modulefiles to Rocky8 (#733)
InnocentSouopgui-NOAA Apr 25, 2024
8a85d7c
Add _CLDDET.NL to fix and activate CADS in global_4denvar ctest (#740)
wx20jjung Apr 29, 2024
a3a2633
nread bug in read_radar.f90 (#738)
ShunLiu-NOAA Apr 30, 2024
38bdb95
Add module file to compile on AWS (#742)
weihuang-jedi May 7, 2024
88aaa63
Merge branch 'NOAA-EMC:develop' into develop
ADCollard May 7, 2024
042e1d7
Add additional geoval and obs outputs
ADCollard May 7, 2024
ebeaba1
add license (#745)
RussTreadon-NOAA May 8, 2024
c3644a6
Bring branch up to develop
ADCollard May 9, 2024
5be3fa9
Add virtual temperature information
ADCollard May 9, 2024
67cddc0
Bug fixes
ADCollard May 9, 2024
59d7578
Update module files to build gsi on Gaea-C5 (#746)
DavidBurrows-NCO May 20, 2024
6cd87ae
Bug fixes
ADCollard May 30, 2024
8d20eb2
Fix type
ADCollard May 30, 2024
f82dc34
add two band sdl to global_4denvar namelist (#758)
RussTreadon-NOAA Jun 21, 2024
6a87460
update path to global ctest model data (#762)
RussTreadon-NOAA Jun 25, 2024
24b731a
Update RRFS regression test cases (#750)
hu5970 Jun 27, 2024
b37b7d7
Update Jet directories (#763)
DavidHuber-NOAA Jun 27, 2024
529bb79
Updates to build and run on Orion Rocky 9 (#764)
RussTreadon-NOAA Jun 28, 2024
2d8a4e5
Merge branch 'develop' of https://github.com/ADCollard/GSI into develop
ADCollard Jul 2, 2024
38e806e
Merge branch 'develop' into feature/ufo_geovals
ADCollard Jul 2, 2024
c6b35d0
Merge remote-tracking branch 'origin/develop' into feature/ufo_geovals
ADCollard Jul 9, 2024
2745c65
Add observer script
ADCollard Jul 31, 2024
2e62d48
Fix iodaconv.sh path
ADCollard Jul 31, 2024
96aacb6
Small fixes
ADCollard Jul 31, 2024
c069aec
update path
ADCollard Aug 1, 2024
fbc19df
Merge branch 'feature/ufo_geovals' of https://github.com/ADCollard/GS…
ADCollard Aug 1, 2024
235018e
Remove duplicate output
ADCollard Aug 6, 2024
47a6db4
Fix variable types in setupoz.f90
ADCollard Aug 6, 2024
0dcda32
Fix variable types in setupoz.f90
ADCollard Aug 6, 2024
73062e7
Make sure aveage surface temperature is included
ADCollard Aug 8, 2024
ba90137
Add instruments
ADCollard Aug 12, 2024
fd6be62
Use CRTM 2.4.0.1
ADCollard Aug 14, 2024
d9e7c54
Additional changes for CRTM
ADCollard Aug 15, 2024
6f7da62
Fix virtual temperature
ADCollard Oct 10, 2024
0fe60bb
Fix virtual temperature
ADCollard Oct 10, 2024
bfbca87
Fix time window
ADCollard Oct 17, 2024
28bf87d
Add AVHRR cloud fraction
ADCollard Oct 17, 2024
d7ddda2
Merge branch 'feature/ufo_geovals' of https://github.com/ADCollard/GS…
ADCollard Oct 17, 2024
fe5f1d2
fic paren
ADCollard Oct 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for zero total ozone pressure in EnKF (issue #625) (#626)
The fix involves setting the pressure to 0.001Pa for ozone obs that have
zero pressure (to avoid Inf when log(p) calculated), and turning off
ob-space vertical localization. Has no effect on current operational
setup which uses model-space vertical localization (modelspace_vloc=T).

---------

Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>
jswhit and jswhit2 authored Sep 22, 2023
commit aa656c6ee23d9a8d253be3dad95615b29ac0d033
8 changes: 7 additions & 1 deletion src/enkf/enkf_obsmod.f90
Original file line number Diff line number Diff line change
@@ -262,7 +262,6 @@ subroutine readobs()
allocate(corrlengthsq(nobstot),lnsigl(nobstot),obtimel(nobstot))
lnsigl=1.e10
do nob=1,nobstot
oblnp(nob) = -log(obpress(nob)) ! distance measured in log(p) units
if (obloclon(nob) < zero) obloclon(nob) = obloclon(nob) + 360._r_single
radlon=deg2rad*obloclon(nob)
radlat=deg2rad*obloclat(nob)
@@ -283,6 +282,13 @@ subroutine readobs()
lnsigl(nob)=latval(deglat,lnsigcutoffnh,lnsigcutofftr,lnsigcutoffsh)
end if
endif
! total column ozone has pressure set to zero, set to 0.001Pa
! and turn vertical localization off (no effect if modelspace_vloc=T)
if (obpress(nob) < 0.001 .and. obtype(nob)(1:3) .eq. ' oz') then
lnsigl(nob) = 1.e30 ! turn ob-space vert localization off
obpress(nob) = 0.001 ! set to a non-zero value
endif
oblnp(nob) = -log(obpress(nob)) ! distance measured in log(p) units
corrlengthsq(nob)=latval(deglat,corrlengthnh,corrlengthtr,corrlengthsh)**2
if ( (obtype(nob)(1:3) == 'dbz' .or. obtype(nob)(1:3) == ' rw') .and. l_use_enkf_directZDA ) then
corrlengthsq(nob)=latval(deglat,corrlengthrdrnh,corrlengthrdrtr,corrlengthrdrsh)**2