Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Hercules #23

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

DavidHuber-NOAA
Copy link
Collaborator

This adds support for the Hercules platform. This has only been build tested, but will be cycle tested in the global workflow shortly. This will resolve #22.

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review December 19, 2023 18:50
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as draft December 19, 2023 20:33
@DavidHuber-NOAA
Copy link
Collaborator Author

There appears to be a bug in the ncio library on Hercules resulting in an HDF5 error when attempting to create a dataset. A bug report has been written in JCSDA/spack-stack#916 with more details.

@DavidHuber-NOAA
Copy link
Collaborator Author

It appears that this is a problem with netCDF4 and not the NCIO library after all. The UFS model folks are reporting a very similar issue with their RTs (see ufs-community/ufs-weather-model#2015). @DusanJovic-NOAA just noted that the I_MPI_EXTRA_FILESYSTEM=ON may fix the issue. I tried this out on my test case and it worked 10 out of 10 times, so I think we have a pathway forward! I will add this variable to the global-workflow/envs/HERCULES.env for the fcst, efcs, and analcalc jobs.

@DavidHuber-NOAA DavidHuber-NOAA self-assigned this Jan 3, 2024
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review January 3, 2024 20:05
@DavidHuber-NOAA
Copy link
Collaborator Author

This ran for a total of 46 cycles over C96/C48 and C384/C192 resolution tests without a single HDF5 error, or any other issue, so I believe this is ready to go.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidHuber-NOAA
Copy link
Collaborator Author

This was tested on Hera as well over 5 cycles and ran successfully each time.

On a different note, the CI sp version (2.5.0) is newer than the one used to compile/run on systems (2.3.3). When version 2.3.3 is requested, both 2.3.3 and 2.5.0 are concretized by spack (I believe this is because ip requires sp and defaults to the newest version, which is 2.5.0). This causes CI to fail when attempting to build. This was encountered during the UFS_Utils upgrade where @AlexanderRichert-NOAA made the suggestion to change to 2.5.0.

@aerorahul
Copy link
Contributor

@RussTreadon-NOAA
If there is no objection, we would like to merge this so we can continue Hercules porting for the cycled system.

@RussTreadon-NOAA
Copy link
Contributor

If @DavidHuber-NOAA is satisfied, that's enough for me. I do not monitor this repo.

@aerorahul aerorahul merged commit 90481d9 into NOAA-EMC:develop Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port to Hercules
3 participants