Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FIXgdas to FIXgfs/gdas #932

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

CoryMartin-NOAA
Copy link
Contributor

Related to NOAA-EMC/global-workflow#2184

Needs to be merged in coordination with the workflow changes.

Removes the usage of FIXgdas and instead uses FIXgfs/gdas as the global-workflow is removing all FIX* variables except for FIXgfs

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @CoryMartin-NOAA ! :)

@jiaruidong2017
Copy link
Collaborator

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

@KateFriedman-NOAA
Copy link
Member

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

@jiaruidong2017 Thanks for noting this. I am making that change in global-workflow per feedback from @CoryMartin-NOAA NOAA-EMC/global-workflow#2184 (comment)

@jiaruidong2017
Copy link
Collaborator

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

Sorry, that is in the global-workflow.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 984ecbe into develop Feb 21, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/remove_FIXgdas branch February 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants