Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NOAA-EMC/GDASApp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e514b926561bfc8fa3de741876505aff74255c95
Choose a base ref
...
head repository: NOAA-EMC/GDASApp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9ab7994a0caf6b201613dd7e7ceae482ffa600e0
Choose a head ref
  • 5 commits
  • 29 files changed
  • 6 contributors

Commits on Nov 15, 2024

  1. Enable the manual operation of the marine verification tool (#1373)

    #### This PR enables the Marine Verification Tool to run outside of the
    g-w CI workflow by submitting an `sbatch` job manually on Hera
    
    Includes,
    - Vrfy task run by a simple driver in the offline #1345 
    - Improve cosmetic issues we found #1349 
    - Bug fixes and more #1314 
    - ~~Move `exgdas_global_marine_analysis_vrfy.py` to `scripts/old`
    directory~~
    
    Most up-to-date plots can be found at
    ```
    /scratch1/NCEPDEV/da/Mindo.Choi/sandbox/marine_vrfy/gdas.20210827/00/analysis/ocean/vrfy_final_PR
    ```
    
    The wall time is as follows:
    ```
    [Mindo.Choi@hfe02 vrfy]$ sacct -j 2477688 --format=JobID,JobName,State,ExitCode,Elapsed
    JobID           JobName      State ExitCode    Elapsed
    ------------ ---------- ---------- -------- ----------
    2477688      marine_vr+  COMPLETED      0:0   00:11:54
    2477688.bat+      batch  COMPLETED      0:0   00:11:54
    2477688.ext+     extern  COMPLETED      0:0   00:11:54
    ```
    
    Additional plotting work will be added by consolidating vrfy task as
    follows:
    - SST/SSH time series
    - Omb time series
    - Spatial SSH/SST/OHC
    - HTML (?)
    
    Close #1314 , Close #1345 , Close #1349
    
    ---------
    
    Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
    apchoiCMD and guillaumevernieres authored Nov 15, 2024
    Copy the full SHA
    2bcedf2 View commit details

Commits on Nov 20, 2024

  1. Fixes gridgen problem and localization for LETKF (#1372)

    Adds the `gridgen.yaml ` back after being removed to` jcb-gdas`, to
    allow LETKF to work with a fix within GDASApp. This is a temporary fix
    until the LETKF task can be converted to using the jcb yamls.
    
    Also adds `obs localization` to remaining obs config files - this will
    have to likewise be carried over to whatever is being used with the obs
    list.
    AndrewEichmann-NOAA authored Nov 20, 2024
    Copy the full SHA
    71aef36 View commit details
  2. Add variable rescaling for aerosol species (#1339)

    This is a draft PR for additions to chem_diagb.h that could allow for a
    variable rescaling (rs) for each aerosol species. It does not yet
    include a way to read the values in from a yaml or config file. The it
    compiles and runs, but I have not yet tested it using 3dvar. And it
    still has lots of print statements used for testing. It runs in about 40
    seconds at C96, and is probably slowed down by the print statements. Any
    comments will be helpful.
    
    Also, note the if statement. I was unsure of the dimensions of an array,
    so I put in a test. I'll remove it along with the print statements.
    andytangborn authored Nov 20, 2024
    Copy the full SHA
    15c29b1 View commit details

Commits on Nov 21, 2024

  1. Copy the full SHA
    0218abf View commit details

Commits on Nov 22, 2024

  1. Comment out rescale section for aero B (#1382)

    Closes #1381 
    
    This PR comments out the species dependent rescaling factor YAML section
    until we have the corresponding workflow changes added
    CoryMartin-NOAA authored Nov 22, 2024
    Copy the full SHA
    9ab7994 View commit details
Loading