Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds image and updates finfish_traits with latest data from Bart #231

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

BBeltz1
Copy link
Collaborator

@BBeltz1 BBeltz1 commented Feb 6, 2025

Added image from Chris Hunt (previously included as .pdf, converted to .png)
Updated finfish_traits with latest data from Bart (reran his analysis with our survdat pull to be consistent with other indicators)

Merge pull request #228 from NOAA-EDAB/fixes_for_catalog
Bart DiFiore updated this dataset using the SOE team's survdat pull to stay consistent with other indicators
@BBeltz1 BBeltz1 requested a review from sgaichas February 6, 2025 17:53
@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Feb 6, 2025

Tacked on the removal of pelagic sharks from the rec_hms dataset and its plot function
Updated lps_sharks and its get function to include new dataset from the HMS team
Created plot function for lps sharks indicator (plot_lps_sharks)

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Feb 6, 2025

@sgaichas happy to iterate plot_lps_sharks if you want it changed. currently it matches the format of plot_rec_hms but it does currently show all available information (species and total) instead of only the aggregate pelagic shark group. I also kept the scale in 1000s of fish to be consistent with the other sharks plot, but this dataset has far fewer total fish so the scale is in single digits.

image

Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I tweaked the lps plot a bit and added the lm to both, finfish traits update seems to work

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Feb 7, 2025

@sgaichas i changed EJ to "social-demographics" for plot_wind_port. would you like to check it before i merge this?

@sgaichas
Copy link
Member

sgaichas commented Feb 7, 2025

looks good, thank you

@BBeltz1 BBeltz1 merged commit db5114e into dev Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants