Update heatwave and heatwave_year with GLORYS bottom data through 11-26-2024

[BBeltz1]

Single commit to update extreme event indicators with latest data file provided by Joe.

[sgaichas]

Are these plotting the exact same data using plot_heatwave_year for the varName = Surface and varName = withtrend arguments?

[andybeet]

those plots are identical. The attributes need updating too

[BBeltz1]

Ah yes, you're right. This is a result of Vince's decision that trended series should be excluded from these indicators. Now that we've internalized this, we can choose to either run the trended series OR we can remove trended options from the plot functions and only include detrended series.

[sgaichas]

@BBeltz1 I think we need to change the dataset to fix this. The current dataset shows 3 variables:

> unique(ecodata::heatwave_year$Var)
[1] "Surface"          "SurfaceDetrended" "BottomDetrended" 

are Surface and SurfaceDetrended the same in the dataset? from the plots it looks like they must be, but the plot code assumes Surface is not detrended. removing the withtrend option from the plot code still leaves ambiguous data in the dataset.

[BBeltz1]

I just pushed a commit removing the trended surface time series from both heatwave and heatwave_year, as well as the associated plot functions. Thanks for catching that.

[sgaichas]

looks good, thanks, I just updated the documentation so this should be good to go