Move assign_unknowns higher up #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Moved the
assign_unknownsfunction higher up the order of operations inget_comland_data. Now operates on raw data then allows user to aggregate by fleet/area AFTER unknowns are "imputed". Rather than allowing the user to aggregate data then assign unknowns based on aggregated data. This makes more sense and reduces the need to change arguments inunkVarandknStratato match aggregation choice.Changed
get_comdisc_data.rfunction to work with change inaggregate_areaflags (applyProps)check_argument_validationfunction changes based on aboveNOTE: All SOE indicators have been calculated based on this change (
comdat,bennet) - minimal differences. Haven't looked to see if this resolves the shellfish issue seen in the 2024 report (missing AREA/EPU being assigned to wrong EPU)